third_party/WebKit/LayoutTests/fast/multicol/pushed-line-affected-by-float.html - Issue 1905923002: Don't lose the pagination strut when a line is re-created.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/multicol/pushed-line-affected-by-float.html

Issue 1905923002: Don't lose the pagination strut when a line is re-created. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Wrong relative path to resources/ Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../../resources/check-layout.js"></script>

	3 <style>

	4 #multicol { position:relative; columns:2; width:100px; line-height:20px; bac kground:black; }

	5 #float { float:right; width:30px; height:30px; background:blue; break-inside :avoid; }

	6 </style>

	7 <p>There should be a blue box in the top right corner of the black box.</p>

	8 <div data-expected-height="40" id="multicol">
	eae 2016/04/21 16:44:21 This might be better as a reftest as it currently This might be better as a reftest as it currently only asserts the height of the container and y position of the child. mstensho (USE GERRIT) 2016/04/21 18:56:59 Yeah, that's the weakness about check-layout tests Show quoted text On 2016/04/21 16:44:21, eae wrote: > This might be better as a reftest as it currently only asserts the height of the > container and y position of the child. Yeah, that's the weakness about check-layout tests. You can add as many assertions as you like, but there may still be unforeseen ways of breaking the layout that will only show up on a reftest. In this case I wanted to make sure that the balancer ended up with a 40px tall multicol container, so that the float would end up at the exact top of the second column. The requirement about being right-aligned as well was just to make the test human-friendly (since "at the top of the second column" is a bit harder to observe than "top-right corner"). Anyway, I tend to like reftests, although they are slower. So, since that's what you suggest, I'll just do that. :) Done.
	9 x<br>

	10 <div data-offset-y="0" id="float"></div>

	11 x<br>

	12 x<br>

	13 </div>

	14 <script>

	15 checkLayout("#multicol");

	16 </script>

OLD	NEW

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/multicol/pushed-line-affected-by-float-expected.txt » ('j') | no next file with comments »