X87: Change the test case for X87 RunTruncateFloat32ToUint32.

X87: Change the test case for X87 RunTruncateFloat32ToUint32.

  The CL #35651 (https://codereview.chromium.org/1858323003) exposed one hiden issue in RunTruncateFloat32ToUint32 test cases and X87 failed at it.

  Here is the issue in RunTruncateFloat32ToUint32:
  For float input = static_cast<float>(*i), the x87 GCC would optimize the input viariable in float floating register for release build.

  The problem is:
  SSE float register has single precision rounding semantic While X87 register hasn't when directly use floating register value. It will cause the value of input viariable has
  different precision for IA32 and X87 port. So static_cast<uint32_t>(input) will be different for IA32 and X87 port too.
  This led to CHECK_EQ(static_cast<uint32_t>(input), m.Call(input)) fail although V8 turbofan JITTed code m.Call(input) has exactly same result in both X87 and IA32 port.

  So we add the following sentence to do type cast to keep the single precision for RunTruncateFloat32ToUint32 by forcing the input viariable get value from memory insread of
  floating register.
  Such as: volatile float input = static_cast<float>(*i).

BUG=

Committed: https://crrev.com/d5ffbfefd9b7e813588fe85579b5fef2dab79d29
Cr-Commit-Position: refs/heads/master@{#35689}

[zhengxing.li, 2016-04-21 07:03:39]

zhengxing.li@intel.com changed reviewers:
+ chunyang.dai@intel.com, titzer@chromium.org, weiliang.lin@intel.com

[zhengxing.li, 2016-04-21 07:03:40]

PTAL, thanks!

[zhengxing.li, 2016-04-21 07:04:45]

zhengxing.li@intel.com changed reviewers:
+ bmeurer@chromium.org

[zhengxing.li, 2016-04-21 07:04:45]

PTAL, thanks!

[titzer, 2016-04-21 07:09:00]

lgtm

https://codereview.chromium.org/1905883002/diff/1/test/cctest/compiler/test-r...
File test/cctest/compiler/test-run-machops.cc (right):

https://codereview.chromium.org/1905883002/diff/1/test/cctest/compiler/test-r...
test/cctest/compiler/test-run-machops.cc:4020: {FOR_UINT32_INPUTS(i){volatile
float input = static_cast<float>(*i);
This somehow got formatted strangely. Maybe disable clang format for this ?

[zhengxing.li, 2016-04-21 07:11:42]

On 2016/04/21 07:09:00, titzer wrote:
> lgtm
> 
>
https://codereview.chromium.org/1905883002/diff/1/test/cctest/compiler/test-r...
> File test/cctest/compiler/test-run-machops.cc (right):
> 
>
https://codereview.chromium.org/1905883002/diff/1/test/cctest/compiler/test-r...
> test/cctest/compiler/test-run-machops.cc:4020: {FOR_UINT32_INPUTS(i){volatile
> float input = static_cast<float>(*i);
> This somehow got formatted strangely. Maybe disable clang format for this ?

Yes, I feel strange too. the git cl format will generate this format.

So How can I disable the clang format when I use "git cl format"?

Thanks!

[titzer, 2016-04-21 08:23:03]

On 2016/04/21 07:11:42, zhengxing.li wrote:
> On 2016/04/21 07:09:00, titzer wrote:
> > lgtm
> > 
> >
>
https://codereview.chromium.org/1905883002/diff/1/test/cctest/compiler/test-r...
> > File test/cctest/compiler/test-run-machops.cc (right):
> > 
> >
>
https://codereview.chromium.org/1905883002/diff/1/test/cctest/compiler/test-r...
> > test/cctest/compiler/test-run-machops.cc:4020:
{FOR_UINT32_INPUTS(i){volatile
> > float input = static_cast<float>(*i);
> > This somehow got formatted strangely. Maybe disable clang format for this ?
> 
> Yes, I feel strange too. the git cl format will generate this format.
> 
> So How can I disable the clang format when I use "git cl format"?
> 
> Thanks!

// clang-format off
// clang-format on

[zhengxing.li, 2016-04-21 08:46:18]

On 2016/04/21 08:23:03, titzer wrote:
> On 2016/04/21 07:11:42, zhengxing.li wrote:
> > On 2016/04/21 07:09:00, titzer wrote:
> > > lgtm
> > > 
> > >
> >
>
https://codereview.chromium.org/1905883002/diff/1/test/cctest/compiler/test-r...
> > > File test/cctest/compiler/test-run-machops.cc (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/1905883002/diff/1/test/cctest/compiler/test-r...
> > > test/cctest/compiler/test-run-machops.cc:4020:
> {FOR_UINT32_INPUTS(i){volatile
> > > float input = static_cast<float>(*i);
> > > This somehow got formatted strangely. Maybe disable clang format for this
?
> > 
> > Yes, I feel strange too. the git cl format will generate this format.
> > 
> > So How can I disable the clang format when I use "git cl format"?
> > 
> > Thanks!
> 
> // clang-format off
> // clang-format on

Thanks, titzer.

I used another method to re-format this CL, please review it again, thanks!

[titzer, 2016-04-21 08:48:07]

lgtm

[zhengxing.li, 2016-04-21 08:48:43]

On 2016/04/21 08:48:07, titzer wrote:
> lgtm

Got it, thanks!

[zhengxing.li, 2016-04-21 08:48:48]

The CQ bit was checked by zhengxing.li@intel.com

[commit-bot: I haz the power, 2016-04-21 08:48:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1905883002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1905883002/20001

[commit-bot: I haz the power, 2016-04-21 09:10:24]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-22 19:14:13]

Description was changed from

==========
X87: Change the test case for X87 RunTruncateFloat32ToUint32.

  The CL #35651 (https://codereview.chromium.org/1858323003) exposed one hiden
issue in RunTruncateFloat32ToUint32 test cases and X87 failed at it.

  Here is the issue in RunTruncateFloat32ToUint32:
  For float input = static_cast<float>(*i), the x87 GCC would optimize the input
viariable in float floating register for release build.

  The problem is:
  SSE float register has single precision rounding semantic While X87 register
hasn't when directly use floating register value. It will cause the value of
input viariable has
  different precision for IA32 and X87 port. So static_cast<uint32_t>(input)
will be different for IA32 and X87 port too.
  This led to CHECK_EQ(static_cast<uint32_t>(input), m.Call(input)) fail
although V8 turbofan JITTed code m.Call(input) has exactly same result in both
X87 and IA32 port.

  So we add the following sentence to do type cast to keep the single precision
for RunTruncateFloat32ToUint32 by forcing the input viariable get value from
memory insread of
  floating register.
  Such as: volatile float input = static_cast<float>(*i).

BUG=
==========

to

==========
X87: Change the test case for X87 RunTruncateFloat32ToUint32.

  The CL #35651 (https://codereview.chromium.org/1858323003) exposed one hiden
issue in RunTruncateFloat32ToUint32 test cases and X87 failed at it.

  Here is the issue in RunTruncateFloat32ToUint32:
  For float input = static_cast<float>(*i), the x87 GCC would optimize the input
viariable in float floating register for release build.

  The problem is:
  SSE float register has single precision rounding semantic While X87 register
hasn't when directly use floating register value. It will cause the value of
input viariable has
  different precision for IA32 and X87 port. So static_cast<uint32_t>(input)
will be different for IA32 and X87 port too.
  This led to CHECK_EQ(static_cast<uint32_t>(input), m.Call(input)) fail
although V8 turbofan JITTed code m.Call(input) has exactly same result in both
X87 and IA32 port.

  So we add the following sentence to do type cast to keep the single precision
for RunTruncateFloat32ToUint32 by forcing the input viariable get value from
memory insread of
  floating register.
  Such as: volatile float input = static_cast<float>(*i).

BUG=

Committed: https://crrev.com/d5ffbfefd9b7e813588fe85579b5fef2dab79d29
Cr-Commit-Position: refs/heads/master@{#35689}
==========

[commit-bot: I haz the power, 2016-04-22 19:14:14]

Patchset 2 (id:??) landed as
https://crrev.com/d5ffbfefd9b7e813588fe85579b5fef2dab79d29
Cr-Commit-Position: refs/heads/master@{#35689}