Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1387)

Issue 1858323003: [turbofan] Length and index2 are unsigned in CheckedLoad/CheckedStore. (Closed)

Created:
4 years, 8 months ago by titzer
Modified:
4 years, 8 months ago
Reviewers:
Benedikt Meurer, ahaas
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Length and index2 are unsigned in CheckedLoad/CheckedStore. Also factor out test cases from test-run-machops.cc into test-run-load-store.cc BUG=chromium:599717 LOG=Y Committed: https://crrev.com/b994ad45b089c64eb253f63526723ffc2a0c86c6 Cr-Commit-Position: refs/heads/master@{#35651}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : rebase #

Patch Set 4 : Unused function #

Total comments: 7

Patch Set 5 : git cl try #

Unified diffs Side-by-side diffs Delta from patch set Stats (+977 lines, -274 lines) Patch
M src/compiler/code-generator-impl.h View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
M src/compiler/x64/code-generator-x64.cc View 1 2 3 4 9 chunks +12 lines, -17 lines 0 comments Download
M test/cctest/cctest.gyp View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A test/cctest/compiler/test-run-load-store.cc View 1 2 3 1 chunk +911 lines, -0 lines 0 comments Download
M test/cctest/compiler/test-run-machops.cc View 1 2 4 chunks +0 lines, -257 lines 0 comments Download
A test/mjsunit/regress/regress-599717.js View 1 2 1 chunk +25 lines, -0 lines 0 comments Download
A test/mjsunit/regress/regress-599719.js View 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
titzer
4 years, 8 months ago (2016-04-19 10:34:43 UTC) #2
ahaas
lgtm https://codereview.chromium.org/1858323003/diff/60001/test/cctest/compiler/test-run-load-store.cc File test/cctest/compiler/test-run-load-store.cc (right): https://codereview.chromium.org/1858323003/diff/60001/test/cctest/compiler/test-run-load-store.cc#newcode410 test/cctest/compiler/test-run-load-store.cc:410: const int32_t kNumElems = 27; Is there a ...
4 years, 8 months ago (2016-04-19 17:57:28 UTC) #4
Benedikt Meurer
LGTM with nit. https://codereview.chromium.org/1858323003/diff/60001/src/compiler/code-generator-impl.h File src/compiler/code-generator-impl.h (right): https://codereview.chromium.org/1858323003/diff/60001/src/compiler/code-generator-impl.h#newcode47 src/compiler/code-generator-impl.h:47: return bit_cast<uint32_t>(ToConstant(instr_->InputAt(index)).ToInt32()); Nit: return bit_cast<uint32_t>(InputInt32(index));
4 years, 8 months ago (2016-04-20 04:06:28 UTC) #5
titzer
https://codereview.chromium.org/1858323003/diff/60001/src/compiler/code-generator-impl.h File src/compiler/code-generator-impl.h (right): https://codereview.chromium.org/1858323003/diff/60001/src/compiler/code-generator-impl.h#newcode47 src/compiler/code-generator-impl.h:47: return bit_cast<uint32_t>(ToConstant(instr_->InputAt(index)).ToInt32()); On 2016/04/20 04:06:28, Benedikt Meurer wrote: > ...
4 years, 8 months ago (2016-04-20 09:02:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1858323003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1858323003/80001
4 years, 8 months ago (2016-04-20 09:32:27 UTC) #9
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 8 months ago (2016-04-20 09:34:27 UTC) #11
nodir1
4 years, 8 months ago (2016-04-22 18:43:57 UTC) #13
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/b994ad45b089c64eb253f63526723ffc2a0c86c6
Cr-Commit-Position: refs/heads/master@{#35651}

Powered by Google App Engine
This is Rietveld 408576698