Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1152)

Unified Diff: net/tools/quic/quic_dispatcher.h

Issue 1905843003: Split out QuicAlarm creation from QuicConnectionHelper to new QuicAlarmFactory. No behavior change,… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@119753783
Patch Set: Rebase Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/tools/quic/quic_client_session_test.cc ('k') | net/tools/quic/quic_dispatcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/tools/quic/quic_dispatcher.h
diff --git a/net/tools/quic/quic_dispatcher.h b/net/tools/quic/quic_dispatcher.h
index 44e1f5c3d116c8d1eceef70cbcd750e4afa5cc06..452fcc8dc29c2347fdb61d5b49f90a827c3d3100 100644
--- a/net/tools/quic/quic_dispatcher.h
+++ b/net/tools/quic/quic_dispatcher.h
@@ -47,7 +47,8 @@ class QuicDispatcher : public QuicServerSessionVisitor,
QuicDispatcher(const QuicConfig& config,
const QuicCryptoServerConfig* crypto_config,
const QuicVersionVector& supported_versions,
- std::unique_ptr<QuicConnectionHelperInterface> helper);
+ std::unique_ptr<QuicConnectionHelperInterface> helper,
+ std::unique_ptr<QuicAlarmFactory> alarm_factory);
~QuicDispatcher() override;
@@ -192,6 +193,8 @@ class QuicDispatcher : public QuicServerSessionVisitor,
QuicConnectionHelperInterface* helper() { return helper_.get(); }
+ QuicAlarmFactory* alarm_factory() { return alarm_factory_.get(); }
+
QuicPacketWriter* writer() { return writer_.get(); }
// Creates per-connection packet writers out of the QuicDispatcher's shared
@@ -238,6 +241,9 @@ class QuicDispatcher : public QuicServerSessionVisitor,
// The helper used for all connections.
std::unique_ptr<QuicConnectionHelperInterface> helper_;
+ // Creates alarms.
+ std::unique_ptr<QuicAlarmFactory> alarm_factory_;
+
// An alarm which deletes closed sessions.
std::unique_ptr<QuicAlarm> delete_sessions_alarm_;
« no previous file with comments | « net/tools/quic/quic_client_session_test.cc ('k') | net/tools/quic/quic_dispatcher.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698