Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Unified Diff: net/tools/quic/quic_client_session_test.cc

Issue 1905843003: Split out QuicAlarm creation from QuicConnectionHelper to new QuicAlarmFactory. No behavior change,… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@119753783
Patch Set: Rebase Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/tools/quic/quic_client_base.cc ('k') | net/tools/quic/quic_dispatcher.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/tools/quic/quic_client_session_test.cc
diff --git a/net/tools/quic/quic_client_session_test.cc b/net/tools/quic/quic_client_session_test.cc
index 09ace38a364bab16bfeca1c561e9620ecfa945da..414fc55c89b0a51b7c11def24bbcba96026c660b 100644
--- a/net/tools/quic/quic_client_session_test.cc
+++ b/net/tools/quic/quic_client_session_test.cc
@@ -94,7 +94,8 @@ class QuicClientSessionTest : public ::testing::TestWithParam<QuicVersion> {
void Initialize() {
session_.reset();
- connection_ = new PacketSavingConnection(&helper_, Perspective::IS_CLIENT,
+ connection_ = new PacketSavingConnection(&helper_, &alarm_factory_,
+ Perspective::IS_CLIENT,
SupportedVersions(GetParam()));
session_.reset(new TestQuicClientSession(
DefaultQuicConfig(), connection_,
@@ -114,12 +115,13 @@ class QuicClientSessionTest : public ::testing::TestWithParam<QuicVersion> {
QuicCryptoClientStream* stream =
static_cast<QuicCryptoClientStream*>(session_->GetCryptoStream());
CryptoTestUtils::FakeServerOptions options;
- CryptoTestUtils::HandshakeWithFakeServer(&helper_, connection_, stream,
- options);
+ CryptoTestUtils::HandshakeWithFakeServer(&helper_, &alarm_factory_,
+ connection_, stream, options);
}
QuicCryptoClientConfig crypto_config_;
MockConnectionHelper helper_;
+ MockAlarmFactory alarm_factory_;
PacketSavingConnection* connection_;
std::unique_ptr<TestQuicClientSession> session_;
QuicClientPushPromiseIndex push_promise_index_;
« no previous file with comments | « net/tools/quic/quic_client_base.cc ('k') | net/tools/quic/quic_dispatcher.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698