Source/core/xml/XMLHttpRequest.h - Issue 190583004: Revert XMLHttpRequest's receive-as-blob implementation back to use memory until Chromium is fixed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/xml/XMLHttpRequest.h

Issue 190583004: Revert XMLHttpRequest's receive-as-blob implementation back to use memory until Chromium is fixed (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: http/tests/inspector/network/network-xhr-async-response-type-blob.html expectation update Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/http/tests/inspector/network/network-xhr-async-response-type-blob-expected.txt ('k') | Source/core/xml/XMLHttpRequest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/xml/XMLHttpRequest.h

diff --git a/Source/core/xml/XMLHttpRequest.h b/Source/core/xml/XMLHttpRequest.h

index 1aa1731b985519c1f7940477ac41c9ac084bfd8c..ddb6c66c8b1f6efbbde667b4468fd3fe86b9792c 100644

--- a/Source/core/xml/XMLHttpRequest.h

+++ b/Source/core/xml/XMLHttpRequest.h

@@ -155,9 +155,6 @@ private:

virtual void didSendData(unsigned long long bytesSent, unsigned long long totalBytesToBeSent) OVERRIDE;

virtual void didReceiveResponse(unsigned long identifier, const ResourceResponse&) OVERRIDE;

virtual void didReceiveData(const char* data, int dataLength) OVERRIDE;

- // When "blob" is specified as the responseType attribute, didDownloadData

- // is called instead of didReceiveData.

- virtual void didDownloadData(int dataLength) OVERRIDE;

virtual void didFinishLoading(unsigned long identifier, double finishTime) OVERRIDE;

virtual void didFail(const ResourceError&) OVERRIDE;

virtual void didFailRedirectCheck() OVERRIDE;

@@ -240,7 +237,6 @@ private:

RefPtr<Document> m_responseDocument;

RefPtr<SharedBuffer> m_binaryResponseBuilder;

- long long m_downloadedBlobLength;

RefPtr<ArrayBuffer> m_responseArrayBuffer;

bool m_error;