Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 1905813003: [turbofan] Introduce dedicated BitcastWordToTagged machine operator. (Closed)

Created:
4 years, 8 months ago by Benedikt Meurer
Modified:
4 years, 8 months ago
Reviewers:
epertoso
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Introduce dedicated BitcastWordToTagged machine operator. This operator doesn't generate any actual code, but teaches the register allocator that a certain computed pointer value is tagged. This is required to safely implement InnerAllocate (and we also use this for Allocate to be sure that we don't suddenly leak a dangling pointer into the heap somewhere). R=epertoso@chromium.org BUG=v8:4939 LOG=n Committed: https://crrev.com/33c717fba4ea866939a1c02d58a7e2ed1d353f55 Cr-Commit-Position: refs/heads/master@{#35700}

Patch Set 1 #

Patch Set 2 : REBASE. Small fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -4 lines) Patch
M src/code-stub-assembler.cc View 1 3 chunks +5 lines, -4 lines 0 comments Download
M src/compiler/code-assembler.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/instruction-selector.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M src/compiler/machine-operator.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/machine-operator.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/opcodes.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/raw-machine-assembler.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/typer.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/verifier.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
Benedikt Meurer
4 years, 8 months ago (2016-04-21 09:03:52 UTC) #1
Benedikt Meurer
Hey Enrico, Quickfix for the allocate pointer map thing in CodeStubAssembler. Please take a look. ...
4 years, 8 months ago (2016-04-21 09:04:46 UTC) #2
epertoso
lgtm
4 years, 8 months ago (2016-04-21 09:13:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1905813003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1905813003/1
4 years, 8 months ago (2016-04-21 09:38:53 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_chromium_gn_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_chromium_gn_rel/builds/16746)
4 years, 8 months ago (2016-04-21 09:49:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1905813003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1905813003/20001
4 years, 8 months ago (2016-04-21 10:43:59 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-21 11:26:28 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:14:38 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/33c717fba4ea866939a1c02d58a7e2ed1d353f55
Cr-Commit-Position: refs/heads/master@{#35700}

Powered by Google App Engine
This is Rietveld 408576698