[chrome.displaySource] Add common functionality to base video encoder.

[chrome.displaySource] Add common functionality to base video encoder.

This changes video encoder base class by adding functionality common
to all H.264 video encoders.

This part of a Wi-Fi Display video encoder patch series:
 * https://codereview.chromium.org/1905673002/  <-- This CL
   Enhance video encoder base class.
 * https://codereview.chromium.org/1905683002/
   Implement hardware accelerated H.264 video encoder.
 * https://codereview.chromium.org/1900233004/
   Implement software based H.264 video encoder.

BUG=242107
Committed: https://crrev.com/94e6ac39b91ace509bb56803dd4f09f1f85b3060
Cr-Commit-Position: refs/heads/master@{#389098}

[e_hakkinen, 2016-04-20 18:41:55]

Description was changed from

==========
[chrome.displaySource] Extend video encoder with functionality.

This extends Wi-Fi Display video encoder with functionality common to
all H.264 video encoders.

BUG=242107
==========

to

==========
[chrome.displaySource] Enhance video encoder base class.

This enhances Wi-Fi Display video encoder base classs with functionality
common to all H.264 video encoders.

This part of a Wi-Fi Display video encoder patch series:
 * https://codereview.chromium.org/1905673002/  <-- This CL
   Enhance video encoder base class.
 * https://codereview.chromium.org/1905683002/
   Implement hardware accelerated H.264 video encoder.
 * https://codereview.chromium.org/1900233004/
   Implement software based H.264 video encoder.

BUG=242107
==========

[e_hakkinen, 2016-04-20 18:51:49]

eero.hakkinen@intel.com changed reviewers:
+ alexander.shalamov@intel.com, asargent@chromium.org,
mikhail.pozdnyakov@intel.com

[e_hakkinen, 2016-04-22 09:18:27]

PTAL.

[Mikhail, 2016-04-22 09:28:34]

Could you also change the CL title: this is 'adding common functionality' rather
than 'enhancing'

https://codereview.chromium.org/1905673002/diff/1/extensions/renderer/api/dis...
File
extensions/renderer/api/display_source/wifi_display/wifi_display_video_encoder.h
(right):

https://codereview.chromium.org/1905673002/diff/1/extensions/renderer/api/dis...
extensions/renderer/api/display_source/wifi_display/wifi_display_video_encoder.h:86:
void RequestIDRPicture() { send_idr_ = true; }
pls. move body to .cc

https://codereview.chromium.org/1905673002/diff/1/extensions/renderer/api/dis...
extensions/renderer/api/display_source/wifi_display/wifi_display_video_encoder.h:96:
WiFiDisplayVideoEncoder(
explicit

https://codereview.chromium.org/1905673002/diff/1/extensions/renderer/api/dis...
extensions/renderer/api/display_source/wifi_display/wifi_display_video_encoder.h:97:
const scoped_refptr<base::SingleThreadTaskRunner>& media_task_runner);
think we can pass just scoped_refptr<base::SingleThreadTaskRunner> and use move
semantics.

[e_hakkinen, 2016-04-22 09:35:01]

Description was changed from

==========
[chrome.displaySource] Enhance video encoder base class.

This enhances Wi-Fi Display video encoder base classs with functionality
common to all H.264 video encoders.

This part of a Wi-Fi Display video encoder patch series:
 * https://codereview.chromium.org/1905673002/  <-- This CL
   Enhance video encoder base class.
 * https://codereview.chromium.org/1905683002/
   Implement hardware accelerated H.264 video encoder.
 * https://codereview.chromium.org/1900233004/
   Implement software based H.264 video encoder.

BUG=242107
==========

to

==========
[chrome.displaySource] Add common functionality to base video encoder.

This changes video encoder base class by adding functionality common
to all H.264 video encoders.

This part of a Wi-Fi Display video encoder patch series:
 * https://codereview.chromium.org/1905673002/  <-- This CL
   Enhance video encoder base class.
 * https://codereview.chromium.org/1905683002/
   Implement hardware accelerated H.264 video encoder.
 * https://codereview.chromium.org/1900233004/
   Implement software based H.264 video encoder.

BUG=242107
==========

[e_hakkinen, 2016-04-22 09:54:50]

https://codereview.chromium.org/1905673002/diff/1/extensions/renderer/api/dis...
File
extensions/renderer/api/display_source/wifi_display/wifi_display_video_encoder.h
(right):

https://codereview.chromium.org/1905673002/diff/1/extensions/renderer/api/dis...
extensions/renderer/api/display_source/wifi_display/wifi_display_video_encoder.h:86:
void RequestIDRPicture() { send_idr_ = true; }
On 2016/04/22 09:28:34, Mikhail wrote:
> pls. move body to .cc

Done.

https://codereview.chromium.org/1905673002/diff/1/extensions/renderer/api/dis...
extensions/renderer/api/display_source/wifi_display/wifi_display_video_encoder.h:96:
WiFiDisplayVideoEncoder(
On 2016/04/22 09:28:34, Mikhail wrote:
> explicit

Done.

https://codereview.chromium.org/1905673002/diff/1/extensions/renderer/api/dis...
extensions/renderer/api/display_source/wifi_display/wifi_display_video_encoder.h:97:
const scoped_refptr<base::SingleThreadTaskRunner>& media_task_runner);
On 2016/04/22 09:28:34, Mikhail wrote:
> think we can pass just scoped_refptr<base::SingleThreadTaskRunner> and use
move
> semantics.

Done.

[Mikhail, 2016-04-22 10:01:42]

lgtm

[shalamov, 2016-04-22 13:21:16]

lgtm

[e_hakkinen, 2016-04-22 13:45:23]

The CQ bit was checked by eero.hakkinen@intel.com

[commit-bot: I haz the power, 2016-04-22 13:45:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1905673002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1905673002/40001

[commit-bot: I haz the power, 2016-04-22 14:24:14]

Description was changed from

==========
[chrome.displaySource] Add common functionality to base video encoder.

This changes video encoder base class by adding functionality common
to all H.264 video encoders.

This part of a Wi-Fi Display video encoder patch series:
 * https://codereview.chromium.org/1905673002/  <-- This CL
   Enhance video encoder base class.
 * https://codereview.chromium.org/1905683002/
   Implement hardware accelerated H.264 video encoder.
 * https://codereview.chromium.org/1900233004/
   Implement software based H.264 video encoder.

BUG=242107
==========

to

==========
[chrome.displaySource] Add common functionality to base video encoder.

This changes video encoder base class by adding functionality common
to all H.264 video encoders.

This part of a Wi-Fi Display video encoder patch series:
 * https://codereview.chromium.org/1905673002/  <-- This CL
   Enhance video encoder base class.
 * https://codereview.chromium.org/1905683002/
   Implement hardware accelerated H.264 video encoder.
 * https://codereview.chromium.org/1900233004/
   Implement software based H.264 video encoder.

BUG=242107
==========

[commit-bot: I haz the power, 2016-04-22 14:24:15]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-04-22 19:47:09]

Description was changed from

==========
[chrome.displaySource] Add common functionality to base video encoder.

This changes video encoder base class by adding functionality common
to all H.264 video encoders.

This part of a Wi-Fi Display video encoder patch series:
 * https://codereview.chromium.org/1905673002/  <-- This CL
   Enhance video encoder base class.
 * https://codereview.chromium.org/1905683002/
   Implement hardware accelerated H.264 video encoder.
 * https://codereview.chromium.org/1900233004/
   Implement software based H.264 video encoder.

BUG=242107
==========

to

==========
[chrome.displaySource] Add common functionality to base video encoder.

This changes video encoder base class by adding functionality common
to all H.264 video encoders.

This part of a Wi-Fi Display video encoder patch series:
 * https://codereview.chromium.org/1905673002/  <-- This CL
   Enhance video encoder base class.
 * https://codereview.chromium.org/1905683002/
   Implement hardware accelerated H.264 video encoder.
 * https://codereview.chromium.org/1900233004/
   Implement software based H.264 video encoder.

BUG=242107

Committed: https://crrev.com/94e6ac39b91ace509bb56803dd4f09f1f85b3060
Cr-Commit-Position: refs/heads/master@{#389098}
==========

[commit-bot: I haz the power, 2016-04-22 19:47:10]

Patchset 3 (id:??) landed as
https://crrev.com/94e6ac39b91ace509bb56803dd4f09f1f85b3060
Cr-Commit-Position: refs/heads/master@{#389098}