[chrome.displaySource] Add common functionality to base video encoder.

extensions/renderer/api/display_source/wifi_display/wifi_display_video_encoder.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef EXTENSIONS_RENDERER_API_DISPLAY_SOURCE_WIFI_DISPLAY_WIFI_DISPLAY_VIDEO_ENCODER_H_
 #define EXTENSIONS_RENDERER_API_DISPLAY_SOURCE_WIFI_DISPLAY_WIFI_DISPLAY_VIDEO_ENCODER_H_
 
 #include <string>
 
 #include "base/memory/shared_memory.h"
@@ skipping 60 matching lines @@
   // A factory method that creates a new encoder instance from the given
   // |params|, the encoder instance is returned as an argument of
   // |result_callback| ('nullptr' argument means encoder creation failure).
   static void Create(
       const InitParameters& params,
       const VideoEncoderCallback& encoder_callback);
 
   // Encodes the given raw frame. The resulting encoded frame is passed
   // as an |encoded_callback|'s argument which is set via 'SetCallbacks'
   // method.
-  virtual void InsertRawVideoFrame(
-      const scoped_refptr<media::VideoFrame>& video_frame,
-      base::TimeTicks reference_time) = 0;
+  void InsertRawVideoFrame(const scoped_refptr<media::VideoFrame>& video_frame,
+                           base::TimeTicks reference_time);
 
   // Requests the next encoded frame to be an instantaneous decoding refresh
   // (IDR) picture.
-  virtual void RequestIDRPicture() = 0;
+  void RequestIDRPicture() { send_idr_ = true; }

[Mikhail, 2016/04/22 09:28:34]

pls. move body to .cc

[e_hakkinen, 2016/04/22 09:54:50]

Done.

 
   // Sets callbacks for the obtained encoder instance:
   // |encoded_callback| is invoked to return the next encoded frame
   // |error_callback| is invoked to report a fatal encoder error
   void SetCallbacks(const EncodedFrameCallback& encoded_callback,
                     const base::Closure& error_callback);
 
  protected:
   friend class base::RefCountedThreadSafe<WiFiDisplayVideoEncoder>;
-  WiFiDisplayVideoEncoder();
+  WiFiDisplayVideoEncoder(

[Mikhail, 2016/04/22 09:28:34]

explicit

[e_hakkinen, 2016/04/22 09:54:50]

Done.

+      const scoped_refptr<base::SingleThreadTaskRunner>& media_task_runner);

[Mikhail, 2016/04/22 09:28:34]

think we can pass just scoped_refptr<base::SingleThreadTaskRunner> and use move
semantics.

[e_hakkinen, 2016/04/22 09:54:50]

Done.

   virtual ~WiFiDisplayVideoEncoder();
 
+  virtual void InsertFrameOnMediaThread(
+      scoped_refptr<media::VideoFrame> video_frame,
+      base::TimeTicks reference_time,
+      bool send_idr) = 0;
+
   EncodedFrameCallback encoded_callback_;
   base::Closure error_callback_;
+  scoped_refptr<base::SingleThreadTaskRunner> media_task_runner_;
+  bool send_idr_;
 };
 
 }  // namespace extensions
 
 #endif  // EXTENSIONS_RENDERER_API_DISPLAY_SOURCE_WIFI_DISPLAY_WIFI_DISPLAY_VIDEO_ENCODER_H_