Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 1905613002: S390: Fixed LBR, LGBR, LHR, LGHR instructions in simulator. (Closed)

Created:
4 years, 8 months ago by bcleung
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

S390: Fixed LBR, LGBR, LHR, LGHR instructions in simulator. R=joransiu@ca.ibm.com,michael_dawson@ca.ibm.com,mbrandy@us.ibm.com,jyan@ca.ibm.com BUG= Committed: https://crrev.com/5ce4a69a1fb2c8e68e14453db5b3ed8a2b0b717e Cr-Commit-Position: refs/heads/master@{#35675}

Patch Set 1 #

Patch Set 2 : Added LGBR to EVALUATE code #

Patch Set 3 : Added LHR and LGHR to EVAL #

Patch Set 4 : Oops. Forgot to remove a comment. #

Patch Set 5 : Removed existing LGBR, LHR, LGHR evals that redirected to original linear opcode search #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -12 lines) Patch
M src/s390/simulator-s390.cc View 1 2 3 4 5 chunks +40 lines, -12 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1905613002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1905613002/1
4 years, 8 months ago (2016-04-20 15:58:26 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 8 months ago (2016-04-20 15:58:28 UTC) #4
bcleung
4 years, 8 months ago (2016-04-20 15:59:13 UTC) #6
john.yan
lgtm
4 years, 8 months ago (2016-04-20 16:36:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1905613002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1905613002/60001
4 years, 8 months ago (2016-04-20 18:03:22 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1905613002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1905613002/80001
4 years, 8 months ago (2016-04-20 18:20:13 UTC) #14
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 8 months ago (2016-04-20 18:36:53 UTC) #15
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:13:45 UTC) #17
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/5ce4a69a1fb2c8e68e14453db5b3ed8a2b0b717e
Cr-Commit-Position: refs/heads/master@{#35675}

Powered by Google App Engine
This is Rietveld 408576698