Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1905533003: Drop transform-change propagation from LayoutSVGHiddenContainer::layout (Closed)

Created:
4 years, 8 months ago by fs
Modified:
4 years, 8 months ago
Reviewers:
pdr., Stephen Chennney
CC:
fs, blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, krit, eae+blinkwatch, f(malita), gyuyoung2, jchaffraix+rendering, kouhei+svg_chromium.org, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@svg-container-layout-cleanup-5
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Drop transform-change propagation from LayoutSVGHiddenContainer::layout No real transform changes should be detected in LayoutSVGHiddenContainer since it's used for things making up (==roots of) "isolated subtrees". BUG=603956 Committed: https://crrev.com/b035163d0abf61e489593d83b468e6988317d8c2 Cr-Commit-Position: refs/heads/master@{#388578}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Use direct literal argument. #

Patch Set 3 : Reupload #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M third_party/WebKit/Source/core/layout/svg/LayoutSVGHiddenContainer.cpp View 1 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
fs
Neither I nor the layout tests could prove that this was useful for anything... Can ...
4 years, 8 months ago (2016-04-20 15:35:24 UTC) #2
Stephen Chennney
lgtm, with an optional nit. https://codereview.chromium.org/1905533003/diff/1/third_party/WebKit/Source/core/layout/svg/LayoutSVGHiddenContainer.cpp File third_party/WebKit/Source/core/layout/svg/LayoutSVGHiddenContainer.cpp (right): https://codereview.chromium.org/1905533003/diff/1/third_party/WebKit/Source/core/layout/svg/LayoutSVGHiddenContainer.cpp#newcode42 third_party/WebKit/Source/core/layout/svg/LayoutSVGHiddenContainer.cpp:42: const bool transformChanged = ...
4 years, 8 months ago (2016-04-20 16:09:10 UTC) #4
fs
https://codereview.chromium.org/1905533003/diff/1/third_party/WebKit/Source/core/layout/svg/LayoutSVGHiddenContainer.cpp File third_party/WebKit/Source/core/layout/svg/LayoutSVGHiddenContainer.cpp (right): https://codereview.chromium.org/1905533003/diff/1/third_party/WebKit/Source/core/layout/svg/LayoutSVGHiddenContainer.cpp#newcode42 third_party/WebKit/Source/core/layout/svg/LayoutSVGHiddenContainer.cpp:42: const bool transformChanged = false; On 2016/04/20 at 16:09:10, ...
4 years, 8 months ago (2016-04-20 16:42:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1905533003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1905533003/40001
4 years, 8 months ago (2016-04-20 19:57:36 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-04-20 21:28:47 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:26:33 UTC) #11
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/b035163d0abf61e489593d83b468e6988317d8c2
Cr-Commit-Position: refs/heads/master@{#388578}

Powered by Google App Engine
This is Rietveld 408576698