Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 /* | 1 /* |
| 2 * Copyright (C) 2007 Eric Seidel <eric@webkit.org> | 2 * Copyright (C) 2007 Eric Seidel <eric@webkit.org> |
| 3 * | 3 * |
| 4 * This library is free software; you can redistribute it and/or | 4 * This library is free software; you can redistribute it and/or |
| 5 * modify it under the terms of the GNU Library General Public | 5 * modify it under the terms of the GNU Library General Public |
| 6 * License as published by the Free Software Foundation; either | 6 * License as published by the Free Software Foundation; either |
| 7 * version 2 of the License, or (at your option) any later version. | 7 * version 2 of the License, or (at your option) any later version. |
| 8 * | 8 * |
| 9 * This library is distributed in the hope that it will be useful, | 9 * This library is distributed in the hope that it will be useful, |
| 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of | 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of |
| (...skipping 15 matching lines...) Expand all Loading... | |
| 26 | 26 |
| 27 LayoutSVGHiddenContainer::LayoutSVGHiddenContainer(SVGElement* element) | 27 LayoutSVGHiddenContainer::LayoutSVGHiddenContainer(SVGElement* element) |
| 28 : LayoutSVGContainer(element) | 28 : LayoutSVGContainer(element) |
| 29 { | 29 { |
| 30 } | 30 } |
| 31 | 31 |
| 32 void LayoutSVGHiddenContainer::layout() | 32 void LayoutSVGHiddenContainer::layout() |
| 33 { | 33 { |
| 34 ASSERT(needsLayout()); | 34 ASSERT(needsLayout()); |
| 35 LayoutAnalyzer::Scope analyzer(*this); | 35 LayoutAnalyzer::Scope analyzer(*this); |
| 36 // TODO(fs): In what cases do we need this? | |
| 37 bool transformChanged = SVGLayoutSupport::transformToRootChanged(this); | |
| 38 | 36 |
| 39 // When hasRelativeLengths() is false, no descendants have relative lengths | 37 // When hasRelativeLengths() is false, no descendants have relative lengths |
| 40 // (hence no one is interested in viewport size changes). | 38 // (hence no one is interested in viewport size changes). |
| 41 bool layoutSizeChanged = element()->hasRelativeLengths() | 39 bool layoutSizeChanged = element()->hasRelativeLengths() |
| 42 && SVGLayoutSupport::layoutSizeOfNearestViewportChanged(this); | 40 && SVGLayoutSupport::layoutSizeOfNearestViewportChanged(this); |
| 43 | 41 |
| 42 const bool transformChanged = false; | |
|
Stephen Chennney
2016/04/20 16:09:10
I think it's OK to just pass false to the method,
fs
2016/04/20 16:42:48
Since this is the "odd one out" wrt this I guess i
| |
| 44 SVGLayoutSupport::layoutChildren(firstChild(), selfNeedsLayout(), transformC hanged, layoutSizeChanged); | 43 SVGLayoutSupport::layoutChildren(firstChild(), selfNeedsLayout(), transformC hanged, layoutSizeChanged); |
| 45 updateCachedBoundaries(); | 44 updateCachedBoundaries(); |
| 46 clearNeedsLayout(); | 45 clearNeedsLayout(); |
| 47 } | 46 } |
| 48 | 47 |
| 49 void LayoutSVGHiddenContainer::paint(const PaintInfo&, const LayoutPoint&) const | 48 void LayoutSVGHiddenContainer::paint(const PaintInfo&, const LayoutPoint&) const |
| 50 { | 49 { |
| 51 // This subtree does not paint. | 50 // This subtree does not paint. |
| 52 } | 51 } |
| 53 | 52 |
| 54 void LayoutSVGHiddenContainer::absoluteQuads(Vector<FloatQuad>&) const | 53 void LayoutSVGHiddenContainer::absoluteQuads(Vector<FloatQuad>&) const |
| 55 { | 54 { |
| 56 // This subtree does not take up space or paint | 55 // This subtree does not take up space or paint |
| 57 } | 56 } |
| 58 | 57 |
| 59 bool LayoutSVGHiddenContainer::nodeAtFloatPoint(HitTestResult&, const FloatPoint &, HitTestAction) | 58 bool LayoutSVGHiddenContainer::nodeAtFloatPoint(HitTestResult&, const FloatPoint &, HitTestAction) |
| 60 { | 59 { |
| 61 return false; | 60 return false; |
| 62 } | 61 } |
| 63 | 62 |
| 64 } // namespace blink | 63 } // namespace blink |
| OLD | NEW |