Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issue 1905343002: Replace AllowCrossThreadAccess() + ThreadSafeRefCounted pointers with PassRefPtr (Closed)

Created:
4 years, 8 months ago by hiroshige
Modified:
4 years, 7 months ago
Reviewers:
haraken, kinuko, tzik
CC:
chromium-reviews, krit, pdr+graphicswatchlist_chromium.org, drott+blinkwatch_chromium.org, danakj+watch_chromium.org, blink-reviews-platform-graphics_chromium.org, dshwang, jbroman, Justin Novosad, hongchan, Rik, f(malita), blink-reviews, kinuko+watch, Raymond Toy, Stephen Chennney, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@Kuroneko_3_DoNotAllow_AllowCrossThreadAccess_GCed
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace AllowCrossThreadAccess() + ThreadSafeRefCounted with PassRefPtr This CL disallows AllowCrossThreadAccess() with pointers to ThreadSafeRefCounted in platform/CrossThreadCopier.h and replaces AllowCrossThreadAccess() with PassRefPtr in other files where compile failed. BUG=597856 Committed: https://crrev.com/856cfbac0b7c1f14262e00c747c0724e0595a2e8 Cr-Commit-Position: refs/heads/master@{#394079}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : auto-Rebase #

Patch Set 4 : Rebase. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -10 lines) Patch
M third_party/WebKit/Source/modules/webaudio/MediaElementAudioSourceNode.cpp View 1 chunk +1 line, -3 lines 1 comment Download
M third_party/WebKit/Source/modules/webaudio/OfflineAudioDestinationNode.cpp View 1 2 3 2 chunks +2 lines, -5 lines 1 comment Download
M third_party/WebKit/Source/modules/webaudio/ScriptProcessorNode.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/CrossThreadCopier.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/ImageFrameGeneratorTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 29 (14 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1905343002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1905343002/1
4 years, 8 months ago (2016-04-22 13:20:39 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-22 15:50:59 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1905343002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1905343002/20001
4 years, 7 months ago (2016-04-27 06:45:43 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-04-27 08:27:33 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1905343002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1905343002/40001
4 years, 7 months ago (2016-04-27 09:27:37 UTC) #11
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-04-27 11:21:55 UTC) #13
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1905343002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1905343002/60001
4 years, 7 months ago (2016-05-17 03:44:08 UTC) #15
hiroshige
PTAL. https://codereview.chromium.org/1905343002/diff/60001/third_party/WebKit/Source/modules/webaudio/MediaElementAudioSourceNode.cpp File third_party/WebKit/Source/modules/webaudio/MediaElementAudioSourceNode.cpp (right): https://codereview.chromium.org/1905343002/diff/60001/third_party/WebKit/Source/modules/webaudio/MediaElementAudioSourceNode.cpp#newcode180 third_party/WebKit/Source/modules/webaudio/MediaElementAudioSourceNode.cpp:180: createCrossThreadTask(&MediaElementAudioSourceHandler::printCORSMessage, PassRefPtr<MediaElementAudioSourceHandler>(this), m_currentSrcString)); I merged mulitiple lines into ...
4 years, 7 months ago (2016-05-17 03:46:13 UTC) #18
haraken
LGTM
4 years, 7 months ago (2016-05-17 04:18:10 UTC) #19
kinuko
lgtm
4 years, 7 months ago (2016-05-17 05:26:20 UTC) #20
tzik
lgtm
4 years, 7 months ago (2016-05-17 05:28:23 UTC) #21
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-17 05:35:05 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1905343002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1905343002/60001
4 years, 7 months ago (2016-05-17 07:44:59 UTC) #25
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 7 months ago (2016-05-17 07:49:12 UTC) #27
commit-bot: I haz the power
4 years, 7 months ago (2016-05-17 07:50:39 UTC) #29
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/856cfbac0b7c1f14262e00c747c0724e0595a2e8
Cr-Commit-Position: refs/heads/master@{#394079}

Powered by Google App Engine
This is Rietveld 408576698