chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.h - Issue 1905273002: Fix positioning of Mac permission prompts when fullscreen.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.h

Issue 1905273002: Fix positioning of Mac permission prompts when fullscreen. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa_browser_test.mm ('K') | « chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa_browser_test.mm ('k') | chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm » ('j') | chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.h

diff --git a/chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.h b/chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.h

index 8d57f854af9cf6da995569dbb65a67f609590655..21d701139cf8bcbc33a9f23fa5ab6fc2bd6bf00c 100644

--- a/chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.h

+++ b/chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.h

@@ -49,8 +49,8 @@ class PermissionBubbleRequest;

// Should only be used outside this class for tests.

- (NSPoint)getExpectedAnchorPoint;

-// Returns true of the browser has support for the location bar.

+// Returns true of the browser has a visible location bar.

tapted 2016/04/22 05:27:40 nit: of -> if

benwells 2016/04/28 07:32:43 Done.

// Should only be used outside this class for tests.

-- (bool)hasLocationBar;

+- (bool)hasVisibleLocationBar;

@end