Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Unified Diff: content/browser/accessibility/browser_accessibility_win_unittest.cc

Issue 1905263002: Correctly finds line boundaries in objects with rich text on Windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed standard text fields in unit test. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/accessibility/browser_accessibility_win_unittest.cc
diff --git a/content/browser/accessibility/browser_accessibility_win_unittest.cc b/content/browser/accessibility/browser_accessibility_win_unittest.cc
index 889fb81b73b8a2c4501fe0e7751295afbcbf869e..7120304980513562c1453036b2b67adb6d8440b7 100644
--- a/content/browser/accessibility/browser_accessibility_win_unittest.cc
+++ b/content/browser/accessibility/browser_accessibility_win_unittest.cc
@@ -340,6 +340,7 @@ TEST_F(BrowserAccessibilityTest, TestTextBoundaries) {
ui::AXNodeData text_field;
text_field.id = 2;
text_field.role = ui::AX_ROLE_TEXT_FIELD;
+ text_field.state = ui::AX_STATE_EDITABLE;
text_field.AddStringAttribute(ui::AX_ATTR_VALUE, text_value);
std::vector<int32_t> line_start_offsets;
line_start_offsets.push_back(15);
@@ -352,12 +353,14 @@ TEST_F(BrowserAccessibilityTest, TestTextBoundaries) {
ui::AXNodeData static_text1;
static_text1.id = 3;
static_text1.role = ui::AX_ROLE_STATIC_TEXT;
+ static_text1.state = ui::AX_STATE_EDITABLE;
static_text1.AddStringAttribute(ui::AX_ATTR_NAME, line1);
static_text1.child_ids.push_back(4);
ui::AXNodeData inline_box1;
inline_box1.id = 4;
inline_box1.role = ui::AX_ROLE_INLINE_TEXT_BOX;
+ inline_box1.state = ui::AX_STATE_EDITABLE;
inline_box1.AddStringAttribute(ui::AX_ATTR_NAME, line1);
std::vector<int32_t> word_start_offsets1;
word_start_offsets1.push_back(0);
@@ -369,17 +372,20 @@ TEST_F(BrowserAccessibilityTest, TestTextBoundaries) {
ui::AXNodeData line_break;
line_break.id = 5;
line_break.role = ui::AX_ROLE_LINE_BREAK;
+ line_break.state = ui::AX_STATE_EDITABLE;
line_break.AddStringAttribute(ui::AX_ATTR_NAME, "\n");
ui::AXNodeData static_text2;
static_text2.id = 6;
static_text2.role = ui::AX_ROLE_STATIC_TEXT;
+ static_text2.state = ui::AX_STATE_EDITABLE;
static_text2.AddStringAttribute(ui::AX_ATTR_NAME, line2);
static_text2.child_ids.push_back(7);
ui::AXNodeData inline_box2;
inline_box2.id = 7;
inline_box2.role = ui::AX_ROLE_INLINE_TEXT_BOX;
+ inline_box2.state = ui::AX_STATE_EDITABLE;
inline_box2.AddStringAttribute(ui::AX_ATTR_NAME, line2);
std::vector<int32_t> word_start_offsets2;
word_start_offsets2.push_back(0);
@@ -404,6 +410,7 @@ TEST_F(BrowserAccessibilityTest, TestTextBoundaries) {
BrowserAccessibilityWin* text_field_obj =
ToBrowserAccessibilityWin(root_obj->PlatformGetChild(0));
ASSERT_NE(nullptr, text_field_obj);
+ ASSERT_EQ(0U, text_field_obj->PlatformChildCount());
long text_len;
EXPECT_EQ(S_OK, text_field_obj->get_nCharacters(&text_len));
« no previous file with comments | « content/browser/accessibility/browser_accessibility_win.cc ('k') | content/renderer/accessibility/blink_ax_tree_source.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698