content/browser/accessibility/browser_accessibility_win.cc - Issue 1905263002: Correctly finds line boundaries in objects with rich text on Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/accessibility/browser_accessibility_win.cc

Issue 1905263002: Correctly finds line boundaries in objects with rich text on Windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed standard text fields in unit test. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/accessibility/browser_accessibility.cc ('k') | content/browser/accessibility/browser_accessibility_win_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/accessibility/browser_accessibility_win.cc

diff --git a/content/browser/accessibility/browser_accessibility_win.cc b/content/browser/accessibility/browser_accessibility_win.cc

index 98aeb77bc7724b0f3474cdf03ef5a64d6a5a7df0..2ee1691b8d8477b89c6b44ed14e9dd2c5b8b3807 100644

--- a/content/browser/accessibility/browser_accessibility_win.cc

+++ b/content/browser/accessibility/browser_accessibility_win.cc

@@ -4246,6 +4246,8 @@ LONG BrowserAccessibilityWin::FindBoundary(

HandleSpecialTextOffset(text, &start_offset);

if (ia2_boundary == IA2_TEXT_BOUNDARY_WORD)

return GetWordStartBoundary(static_cast<int>(start_offset), direction);

+ if (ia2_boundary == IA2_TEXT_BOUNDARY_LINE)

+ return GetLineStartBoundary(static_cast<int>(start_offset), direction);

ui::TextBoundaryType boundary = IA2TextBoundaryToTextBoundary(ia2_boundary);

const std::vector<int32_t>& line_breaks =