Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 1905253002: Implement matchFamilyStyle for SkFontMgr_fontconfig (Closed)

Created:
4 years, 8 months ago by Tom (Use chromium acct)
Modified:
4 years, 7 months ago
Reviewers:
bsalomon, reed1
CC:
reviews_skia.org, bungeman-chromium, eae, Lei Zhang
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -1 line) Patch
M include/core/SkTypeface.h View 3 chunks +4 lines, -0 lines 0 comments Download
M src/core/SkTypeface.cpp View 2 chunks +18 lines, -0 lines 0 comments Download
M src/fonts/SkFontMgr_fontconfig.cpp View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1905253002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1905253002/1
4 years, 8 months ago (2016-04-22 01:53:31 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 8 months ago (2016-04-22 01:53:32 UTC) #5
Tom (Use chromium acct)
4 years, 8 months ago (2016-04-22 01:56:34 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 07:53:01 UTC) #9
Dry run: No LGTM from a valid reviewer yet. Please ask for an LGTM from a
full Skia committer

Powered by Google App Engine
This is Rietveld 408576698