Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Unified Diff: cloud_print/virtual_driver/win/install/setup.cc

Issue 19052005: Move PathIsWritable, DirectoryExists, ContentsEqual, and TextContentsEqual to the base namespace. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cloud_print/virtual_driver/win/install/setup.cc
diff --git a/cloud_print/virtual_driver/win/install/setup.cc b/cloud_print/virtual_driver/win/install/setup.cc
index e5a249e0d8c7caf7fecd2cf97ebe2778549347a5..510370f0b24ce486f7d20dd32c52100930a1f73c 100644
--- a/cloud_print/virtual_driver/win/install/setup.cc
+++ b/cloud_print/virtual_driver/win/install/setup.cc
@@ -391,7 +391,7 @@ bool IsOSSupported() {
HRESULT RegisterVirtualDriver(const base::FilePath& install_path) {
HRESULT result = S_OK;
- DCHECK(file_util::DirectoryExists(install_path));
+ DCHECK(base::DirectoryExists(install_path));
if (!IsOSSupported()) {
LOG(ERROR) << "Requires XP SP3 or later.";
return HRESULT_FROM_WIN32(ERROR_OLD_WIN_VERSION);
@@ -477,7 +477,7 @@ HRESULT DoRegister(const base::FilePath& install_path) {
HRESULT DoDelete(const base::FilePath& install_path) {
if (install_path.value().empty())
return E_INVALIDARG;
- if (!file_util::DirectoryExists(install_path))
+ if (!base::DirectoryExists(install_path))
return S_FALSE;
Sleep(5000); // Give parent some time to exit.
return base::Delete(install_path, true) ? S_OK : E_FAIL;
@@ -492,7 +492,7 @@ HRESULT DoInstall(const base::FilePath& install_path) {
base::FilePath old_install_path = GetInstallLocation(kUninstallId);
if (!old_install_path.value().empty() &&
install_path != old_install_path) {
- if (file_util::DirectoryExists(old_install_path))
+ if (base::DirectoryExists(old_install_path))
base::Delete(old_install_path, true);
}
CreateUninstallKey(kUninstallId, LoadLocalString(IDS_DRIVER_NAME),
@@ -509,7 +509,7 @@ HRESULT ExecuteCommands() {
base::FilePath exe_path;
if (FAILED(PathService::Get(base::DIR_EXE, &exe_path)) ||
- !file_util::DirectoryExists(exe_path)) {
+ !base::DirectoryExists(exe_path)) {
return HRESULT_FROM_WIN32(ERROR_PATH_NOT_FOUND);
}
« no previous file with comments | « chrome_frame/test/test_with_web_server.cc ('k') | cloud_print/virtual_driver/win/port_monitor/port_monitor.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698