Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issue 19052002: Cleanup sanitize build sed and sh scripts. (Closed)

Created:
7 years, 5 months ago by Nils Barth (inactive)
Modified:
7 years, 1 month ago
CC:
chromium-reviews
Visibility:
Public.

Description

Cleanup sanitize build sed and sh scripts. Minor cleanup: * switch regexes to extended regexes, which remove a few gratuitous backslashes (and makes them less confusing, since basic regexes are so rarely used) * fix . -> \. (which *does* need escaping in either case) * make sed files non-executable, since if executed they just say "don't execute this" * delete blank line (Just noticed these scripts when working on Blink IDL bindings, and made necessary fixes for my changes, but cleaning up while I'm here.) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=211564 R=scottbyer@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=231995

Patch Set 1 #

Patch Set 2 : More fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -16 lines) Patch
M build/sanitize-mac-build-log.sed View 1 3 chunks +5 lines, -7 lines 0 comments Download
M build/sanitize-mac-build-log.sh View 1 chunk +1 line, -2 lines 0 comments Download
M build/sanitize-win-build-log.sed View 2 chunks +3 lines, -5 lines 0 comments Download
M build/sanitize-win-build-log.sh View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Nils Barth (inactive)
Hiyas, Just noticed these scripts when changing Blink IDL compiler, and made a few minor ...
7 years, 5 months ago (2013-07-12 04:10:49 UTC) #1
Scott Byer
lgtm
7 years, 5 months ago (2013-07-12 15:47:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/19052002/2001
7 years, 5 months ago (2013-07-13 05:39:36 UTC) #3
commit-bot: I haz the power
Change committed as 211564
7 years, 5 months ago (2013-07-13 09:56:21 UTC) #4
Nils Barth (inactive)
For reference, reverted in Revert 211564 "Cleanup sanitize build sed and sh scripts." https://codereview.chromium.org/19129002 ...because ...
7 years, 3 months ago (2013-08-30 06:33:31 UTC) #5
Nils Barth (inactive)
Committed patchset #2 manually as r231995 (presubmit successful).
7 years, 1 month ago (2013-10-31 04:21:47 UTC) #6
Nils Barth (inactive)
7 years, 1 month ago (2013-10-31 04:50:37 UTC) #7
Message was sent while issue was closed.
On 2013/10/31 04:21:47, Nils Barth wrote:
> Committed patchset #2 manually as r231995 (presubmit successful).

Verified that permissions updated correctly, so shouldn't cause problems in
check_perms.

Powered by Google App Engine
This is Rietveld 408576698