Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 19129002: Revert 211564 "Cleanup sanitize build sed and sh scripts." (Closed)

Created:
7 years, 5 months ago by tkent
Modified:
7 years, 1 month ago
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 211564 "Cleanup sanitize build sed and sh scripts." check_perms failues on Linux bots. http://build.chromium.org/p/chromium/builders/Linux/builds/40809/steps/check_perms/logs/stdio > /b/build/slave/Linux/build/src/build/sanitize-mac-build-log.sed: Has executable bit but not shebang > /b/build/slave/Linux/build/src/build/sanitize-win-build-log.sed: Has executable bit but not shebang > Cleanup sanitize build sed and sh scripts. > > Minor cleanup: > * switch regexes to extended regexes, > which remove a few gratuitous backslashes > (and makes them less confusing, since basic regexes are so rarely used) > * fix . -> \. (which *does* need escaping in either case) > * make sed files non-executable, > since if executed they just say "don't execute this" > * delete blank line > > (Just noticed these scripts when working on Blink IDL bindings, and made > necessary fixes for my changes, but cleaning up while I'm here.) > > Review URL: https://chromiumcodereview.appspot.com/19052002 TBR=nbarth@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=211566

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -10 lines) Patch
M trunk/src/build/sanitize-mac-build-log.sed View 3 chunks +7 lines, -5 lines 0 comments Download
M trunk/src/build/sanitize-mac-build-log.sh View 1 chunk +2 lines, -1 line 0 comments Download
M trunk/src/build/sanitize-win-build-log.sed View 2 chunks +5 lines, -3 lines 0 comments Download
M trunk/src/build/sanitize-win-build-log.sh View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
tkent
7 years, 5 months ago (2013-07-13 11:54:20 UTC) #1
tkent
Committed patchset #1 manually as r211566.
7 years, 5 months ago (2013-07-13 11:54:32 UTC) #2
Nils Barth (inactive)
Thanks for catching this Kent! However, AFAICT my patch sets the permission correctly (checking locally ...
7 years, 5 months ago (2013-07-13 13:15:27 UTC) #3
tkent
> How do we fix this? Force a full rebuild? I don't know. CQ might ...
7 years, 5 months ago (2013-07-15 22:00:33 UTC) #4
Nils Barth (inactive)
On 2013/07/15 22:00:33, tkent wrote: > > How do we fix this? Force a full ...
7 years, 5 months ago (2013-07-16 05:24:15 UTC) #5
Nils Barth (inactive)
7 years, 1 month ago (2013-10-31 04:53:11 UTC) #6
Message was sent while issue was closed.
To followup (rather later):
CQ doesn't support changing executable bit, per this bug:
Commit queue doesn't change the svn:executable bit
https://code.google.com/p/chromium/issues/detail?id=162196

I've relanded by dcommit, and verified that the mode changed correctly,
so shouldn't cause any problems with check_perms this time.

Powered by Google App Engine
This is Rietveld 408576698