content/renderer/render_view_browsertest.cc - Issue 1905033002: PlzNavigate: Move navigation-level mixed content checks to the browser.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_view_browsertest.cc

Issue 1905033002: PlzNavigate: Move navigation-level mixed content checks to the browser. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@console-security-message

Patch Set: Addressed all jam@ latest comments. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/public/browser/content_browser_client.h ('K') | « content/renderer/render_frame_impl.cc ('k') | content/shell/browser/layout_test/blink_test_controller.h » ('j') | net/url_request/url_request.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/render_view_browsertest.cc

diff --git a/content/renderer/render_view_browsertest.cc b/content/renderer/render_view_browsertest.cc

index 5e5695afb7d2e6d0102d4ed9c07728ee6d9b81fe..1e0bbe636058856106994a973cd17ed3bf871fa0 100644

--- a/content/renderer/render_view_browsertest.cc

+++ b/content/renderer/render_view_browsertest.cc

@@ -686,6 +686,7 @@ TEST_F(RenderViewImplTest, DecideNavigationPolicy) {

blink::WebURLRequest::FetchCredentialsModeInclude);

request.setFetchRedirectMode(blink::WebURLRequest::FetchRedirectModeManual);

request.setFrameType(blink::WebURLRequest::FrameTypeTopLevel);

+ request.setRequestContext(blink::WebURLRequest::RequestContextInternal);

blink::WebFrameClient::NavigationPolicyInfo policy_info(request);

policy_info.navigationType = blink::WebNavigationTypeLinkClicked;

policy_info.defaultPolicy = blink::WebNavigationPolicyCurrentTab;