Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2638)

Unified Diff: content/renderer/render_frame_impl.cc

Issue 1905033002: PlzNavigate: Move navigation-level mixed content checks to the browser. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@console-security-message
Patch Set: Addressed all jam@ latest comments. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_frame_impl.cc
diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc
index be46fd8b8128c5eb43ff8e6d8c75d1861c037bce..0bbdd63c54969071c631eae70c28d4297ee25dc9 100644
--- a/content/renderer/render_frame_impl.cc
+++ b/content/renderer/render_frame_impl.cc
@@ -5,6 +5,7 @@
#include "content/renderer/render_frame_impl.h"
#include <map>
+#include <set>
#include <string>
#include <utility>
#include <vector>
@@ -1575,6 +1576,10 @@ bool RenderFrameImpl::OnMessageReceived(const IPC::Message& msg) {
OnSetHasReceivedUserGesture)
IPC_MESSAGE_HANDLER(FrameMsg_RunFileChooserResponse, OnFileChooserResponse)
IPC_MESSAGE_HANDLER(FrameMsg_ClearFocusedElement, OnClearFocusedElement)
+ IPC_MESSAGE_HANDLER(FrameMsg_BlinkFeatureUsageReport,
+ OnBlinkFeatureUsageReport)
+ IPC_MESSAGE_HANDLER(FrameMsg_MixedContentFoundByTheBrowser,
+ OnMixedContentFoundByTheBrowser)
#if defined(OS_ANDROID)
IPC_MESSAGE_HANDLER(FrameMsg_ActivateNearestFindResult,
OnActivateNearestFindResult)
@@ -5644,6 +5649,23 @@ void RenderFrameImpl::OnClearFocusedElement() {
webview->clearFocusedElement();
}
+void RenderFrameImpl::OnBlinkFeatureUsageReport(const std::set<int>& features) {
+ frame_->blinkFeatureUsageReport(features);
+}
+
+void RenderFrameImpl::OnMixedContentFoundByTheBrowser(
+ const GURL& main_resource_url,
+ const GURL& mixed_content_url,
+ RequestContextType request_context_type,
+ bool was_allowed,
+ bool had_redirect) {
+ auto request_context =
+ static_cast<blink::WebURLRequest::RequestContext>(request_context_type);
+ frame_->mixedContentFoundByTheBrowser(main_resource_url, mixed_content_url,
+ request_context, was_allowed,
+ had_redirect);
+}
+
#if defined(OS_ANDROID)
void RenderFrameImpl::OnActivateNearestFindResult(int request_id,
float x,
@@ -6209,7 +6231,9 @@ void RenderFrameImpl::BeginNavigation(const NavigationPolicyInfo& info) {
info.urlRequest.hasUserGesture(),
info.urlRequest.skipServiceWorker() !=
blink::WebURLRequest::SkipServiceWorker::None,
- GetRequestContextTypeForWebURLRequest(info.urlRequest), initiator_origin);
+ GetRequestContextTypeForWebURLRequest(info.urlRequest),
+ GetMixedContentContextTypeForWebURLRequest(info.urlRequest),
+ initiator_origin);
if (!info.form.isNull()) {
WebSearchableFormData web_searchable_form_data(info.form);

Powered by Google App Engine
This is Rietveld 408576698