Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4409)

Unified Diff: chrome/renderer/content_settings_observer.cc

Issue 1905033002: PlzNavigate: Move navigation-level mixed content checks to the browser. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@console-security-message
Patch Set: Overall code cleanup to request reviewers to PTAL. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/content_settings_observer.cc
diff --git a/chrome/renderer/content_settings_observer.cc b/chrome/renderer/content_settings_observer.cc
index 0c98a21b0dbeee2400d5832d7ae82c6826f87f1d..bda8c967df3de912d6885f9a4e2f82fc024dbb60 100644
--- a/chrome/renderer/content_settings_observer.cc
+++ b/chrome/renderer/content_settings_observer.cc
@@ -399,6 +399,8 @@ bool ContentSettingsObserver::allowMutationEvents(bool default_value) {
bool ContentSettingsObserver::allowDisplayingInsecureContent(
bool allowed_per_settings,
const blink::WebURL& resource_url) {
+ // Note: this implementation is a mirror of
+ // ChromeContentBrowserClient::ShouldAllowDisplayingInsecureContent
ReportInsecureContent(SslInsecureContentType::DISPLAY);
FilteredReportInsecureContentDisplayed(GURL(resource_url));
@@ -414,6 +416,8 @@ bool ContentSettingsObserver::allowRunningInsecureContent(
bool allowed_per_settings,
const blink::WebSecurityOrigin& origin,
const blink::WebURL& resource_url) {
+ // Note: this implementation is a mirror of
+ // ChromeContentBrowserClient::ShouldAllowRunningInsecureContent
FilteredReportInsecureContentRan(GURL(resource_url));
if (!allow_running_insecure_content_ && !allowed_per_settings) {

Powered by Google App Engine
This is Rietveld 408576698