chrome/browser/ui/content_settings/content_setting_bubble_model.cc - Issue 1905033002: PlzNavigate: Move navigation-level mixed content checks to the browser.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/content_settings/content_setting_bubble_model.cc

Issue 1905033002: PlzNavigate: Move navigation-level mixed content checks to the browser. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@console-security-message

Patch Set: Overall code cleanup to request reviewers to PTAL. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/infobars/insecure_content_infobar_delegate.cc ('K') | « chrome/browser/metrics/first_web_contents_profiler.cc ('k') | chrome/browser/ui/tab_helpers.cc » ('j') | components/content_settings/content/common/content_settings_messages.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/content_settings/content_setting_bubble_model.cc

diff --git a/chrome/browser/ui/content_settings/content_setting_bubble_model.cc b/chrome/browser/ui/content_settings/content_setting_bubble_model.cc

index bfd711a8d0e036d125082fc931d49a5f7ec52133..6ea417ba8bfe4ed74b056ba61f4b70252278e270 100644

--- a/chrome/browser/ui/content_settings/content_setting_bubble_model.cc

+++ b/chrome/browser/ui/content_settings/content_setting_bubble_model.cc

@@ -15,6 +15,8 @@

#include "chrome/browser/content_settings/chrome_content_settings_utils.h"

#include "chrome/browser/content_settings/cookie_settings_factory.h"

#include "chrome/browser/content_settings/host_content_settings_map_factory.h"

+#include "chrome/browser/content_settings/mixed_content_settings.h"

+#include "chrome/browser/content_settings/tab_specific_content_settings.h"

#include "chrome/browser/custom_handlers/protocol_handler_registry.h"

#include "chrome/browser/custom_handlers/protocol_handler_registry_factory.h"

#include "chrome/browser/infobars/infobar_service.h"

@@ -981,6 +983,9 @@ void ContentSettingMixedScriptBubbleModel::OnCustomLinkClicked() {

if (!web_contents())

return;

+ MixedContentSettings* mixed_content_settings =

+ MixedContentSettings::FromWebContents(web_contents());

+ mixed_content_settings->AllowRunningOfInsecureContent();

carlosk 2016/07/18 14:37:13 Similarly, should this following code that notifie

web_contents()->SendToAllFrames(

new ChromeViewMsg_SetAllowRunningInsecureContent(MSG_ROUTING_NONE, true));

web_contents()->GetMainFrame()->Send(new ChromeViewMsg_ReloadFrame(