chrome/browser/metrics/first_web_contents_profiler.cc - Issue 1905033002: PlzNavigate: Move navigation-level mixed content checks to the browser.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/metrics/first_web_contents_profiler.cc

Issue 1905033002: PlzNavigate: Move navigation-level mixed content checks to the browser. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@console-security-message

Patch Set: Overall code cleanup to request reviewers to PTAL. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/infobars/insecure_content_infobar_delegate.cc ('K') | « chrome/browser/infobars/insecure_content_infobar_delegate.cc ('k') | chrome/browser/ui/content_settings/content_setting_bubble_model.cc » ('j') | chrome/browser/ui/content_settings/content_setting_bubble_model.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/metrics/first_web_contents_profiler.cc

diff --git a/chrome/browser/metrics/first_web_contents_profiler.cc b/chrome/browser/metrics/first_web_contents_profiler.cc

index 4985a715635ae2eb89e99485ac53f1cb56ed6554..432fd58a0f2e7273db4a7ae61a0529bfd04e3da6 100644

--- a/chrome/browser/metrics/first_web_contents_profiler.cc

+++ b/chrome/browser/metrics/first_web_contents_profiler.cc

@@ -87,6 +87,8 @@ void FirstWebContentsProfiler::DidStartNavigation(

return;

}

+ // TODO(carlosk): this DCHECK is hit when PlzNavigate is enabled. See

+ // crbug.com/610771.

// The first navigation has to be the main frame's.

DCHECK(navigation_handle->IsInMainFrame());