Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Unified Diff: chrome/browser/android/ntp/ntp_snippets_bridge.h

Issue 1905013002: Refine tracking of snippet dismissals. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Formatting Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/ntp/ntp_snippets_bridge.h
diff --git a/chrome/browser/android/ntp/ntp_snippets_bridge.h b/chrome/browser/android/ntp/ntp_snippets_bridge.h
index 0011c99c1254da0398748403cd62618e07628037..088b5d531d0236a4e7331e57b584d9175516300d 100644
--- a/chrome/browser/android/ntp/ntp_snippets_bridge.h
+++ b/chrome/browser/android/ntp/ntp_snippets_bridge.h
@@ -9,6 +9,8 @@
#include "base/android/scoped_java_ref.h"
#include "base/scoped_observer.h"
+#include "base/task/cancelable_task_tracker.h"
+#include "components/history/core/browser/history_service.h"
#include "components/ntp_snippets/ntp_snippets_service.h"
// The C++ counterpart to SnippetsBridge.java. Enables Java code to access
@@ -28,6 +30,12 @@ class NTPSnippetsBridge : public ntp_snippets::NTPSnippetsServiceObserver {
const base::android::JavaParamRef<jobject>& obj,
const base::android::JavaParamRef<jstring>& url);
+ // Checks if the URL has been visited.
+ void SnippetVisited(JNIEnv* env,
+ const base::android::JavaParamRef<jobject>& obj,
+ const base::android::JavaParamRef<jobject>& callback,
+ const base::android::JavaParamRef<jstring>& jurl);
+
static bool Register(JNIEnv* env);
private:
@@ -38,6 +46,8 @@ class NTPSnippetsBridge : public ntp_snippets::NTPSnippetsServiceObserver {
void NTPSnippetsServiceShutdown() override;
ntp_snippets::NTPSnippetsService* ntp_snippets_service_;
+ history::HistoryService* history_service_;
+ base::CancelableTaskTracker tracker_;
// Used to notify the Java side when new snippets have been fetched.
base::android::ScopedJavaGlobalRef<jobject> observer_;

Powered by Google App Engine
This is Rietveld 408576698