Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4135)

Unified Diff: chrome/browser/android/ntp/ntp_snippets_bridge.cc

Issue 1905013002: Refine tracking of snippet dismissals. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Formatting Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/android/ntp/ntp_snippets_bridge.h ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/ntp/ntp_snippets_bridge.cc
diff --git a/chrome/browser/android/ntp/ntp_snippets_bridge.cc b/chrome/browser/android/ntp/ntp_snippets_bridge.cc
index ac248694babf4eb940d85207f0aec7f507f867a5..569b3c7ad2a00554b89b7d5e38618b69b345efed 100644
--- a/chrome/browser/android/ntp/ntp_snippets_bridge.cc
+++ b/chrome/browser/android/ntp/ntp_snippets_bridge.cc
@@ -10,10 +10,12 @@
#include "base/android/jni_array.h"
#include "base/android/jni_string.h"
#include "base/android/scoped_java_ref.h"
+#include "chrome/browser/history/history_service_factory.h"
#include "chrome/browser/ntp_snippets/ntp_snippets_service_factory.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/profiles/profile_android.h"
#include "chrome/browser/profiles/profile_manager.h"
+#include "components/history/core/browser/history_service.h"
#include "components/ntp_snippets/ntp_snippet.h"
#include "components/ntp_snippets/ntp_snippets_service.h"
#include "jni/SnippetsBridge_jni.h"
@@ -23,6 +25,22 @@ using base::android::JavaParamRef;
using base::android::ToJavaArrayOfStrings;
using base::android::ToJavaLongArray;
+namespace {
+
+void SnippetVisitedHistoryRequestCallback(
+ base::android::ScopedJavaGlobalRef<jobject> callback,
+ bool success,
+ const history::URLRow& row,
+ const history::VisitVector& visitVector) {
+ bool visited = success && row.visit_count() != 0;
+
+ JNIEnv* env = base::android::AttachCurrentThread();
+ Java_SnippetsBridge_runCallback(env, callback.obj(),
+ static_cast<jboolean>(visited));
+}
+
+} // namespace
+
static jlong Init(JNIEnv* env,
const JavaParamRef<jobject>& obj,
const JavaParamRef<jobject>& j_profile) {
@@ -49,6 +67,9 @@ NTPSnippetsBridge::NTPSnippetsBridge(JNIEnv* env,
: snippet_service_observer_(this) {
Profile* profile = ProfileAndroid::FromProfileAndroid(j_profile);
ntp_snippets_service_ = NTPSnippetsServiceFactory::GetForProfile(profile);
+ history_service_ =
+ HistoryServiceFactory::GetForProfile(profile,
+ ServiceAccessType::EXPLICIT_ACCESS);
snippet_service_observer_.Add(ntp_snippets_service_);
}
@@ -72,6 +93,19 @@ void NTPSnippetsBridge::DiscardSnippet(JNIEnv* env,
GURL(ConvertJavaStringToUTF8(env, url)));
}
+void NTPSnippetsBridge::SnippetVisited(JNIEnv* env,
+ const JavaParamRef<jobject>& obj,
+ const JavaParamRef<jobject>& jcallback,
+ const JavaParamRef<jstring>& jurl) {
+ base::android::ScopedJavaGlobalRef<jobject> callback(jcallback);
+
+ history_service_->QueryURL(
+ GURL(ConvertJavaStringToUTF8(env, jurl)),
+ false,
+ base::Bind(&SnippetVisitedHistoryRequestCallback, callback),
+ &tracker_);
+}
+
void NTPSnippetsBridge::NTPSnippetsServiceLoaded() {
if (observer_.is_null())
return;
« no previous file with comments | « chrome/browser/android/ntp/ntp_snippets_bridge.h ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698