Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(714)

Issue 1904973003: Revert of Make OffscreenCanvas Transferable (Closed)

Created:
4 years, 8 months ago by xidachen
Modified:
4 years, 8 months ago
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Make OffscreenCanvas Transferable (patchset #20 id:380001 of https://codereview.chromium.org/1862033002/ ) Reason for revert: Could be causing a failure to some unit_tests here: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win%20x64%20Builder%20%28dbg%29/builds/80633 Original issue's description: > Make OffscreenCanvas Transferable > > At this moment, an offscreenCanvas could have an associated HTMLCanvasElement, > and we maintain a WeakPtr to that. Per discussion with esprehn@, > we change the strategy such that an offscreenCanvas holds a int which > is the DOMNodeId for its associated HTMLCanvasElement. > > This change makes offscreenCanvas transferable much easier. In particular, > we just need to pass three int to deserializer, which are width, height > and DOMNodeId of for an offscreenCanvas. > > A kayout test is included to test its correctness. The layout test > includes several things: > 1). Transfer an offscreenCanvas to worker and transfer it back to main, > the width and height attributes should not change. > 2). After transfer, the width/height should be 0. > 3). Transfer a neutered offscreenCanvas should throw an exception. > 4). After getting the offscreenCanvas back from the worker, call getContext('2d') > should work just fine. > 5). Transfer an offscreenCanvas after calling getContext('2d') > should throw an exception. > > BUG=563845 TBR=junov@chromium.org,haraken@chromium.org,xlai@chromium.org,ajuma@chromium.org,sigbjornf@opera.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=563845 Committed: https://crrev.com/bd6b09d886a2a9dcfe4f032df890a4916e35f77e Cr-Commit-Position: refs/heads/master@{#388790}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -417 lines) Patch
D third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-transferable.html View 1 chunk +0 lines, -37 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-transferable-exceptions.html View 1 chunk +0 lines, -54 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-transferable-exceptions-expected.txt View 1 chunk +0 lines, -15 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-transferable-expected.txt View 1 chunk +0 lines, -15 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/resources/OffscreenCanvas-transferable.js View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.h View 3 chunks +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/SerializationTag.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/SerializedScriptValue.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/SerializedScriptValue.cpp View 2 chunks +36 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/SerializedScriptValueFactory.h View 2 chunks +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/SerializedScriptValueFactory.cpp View 4 chunks +2 lines, -48 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/Transferables.h View 1 chunk +5 lines, -4 lines 0 comments Download
D third_party/WebKit/Source/bindings/core/v8/Transferables.cpp View 1 chunk +0 lines, -20 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/v8.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/modules/v8/ScriptValueSerializerForModules.h View 3 chunks +1 line, -8 lines 0 comments Download
M third_party/WebKit/Source/bindings/modules/v8/ScriptValueSerializerForModules.cpp View 6 chunks +4 lines, -72 lines 0 comments Download
M third_party/WebKit/Source/bindings/modules/v8/SerializedScriptValueForModulesFactory.h View 2 chunks +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/bindings/modules/v8/SerializedScriptValueForModulesFactory.cpp View 4 chunks +1 line, -47 lines 0 comments Download
D third_party/WebKit/Source/bindings/modules/v8/TransferablesForModules.h View 1 chunk +0 lines, -31 lines 0 comments Download
M third_party/WebKit/Source/bindings/modules/v8/v8.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/templates/methods.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/canvas/HTMLCanvasElementModule.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/canvas/HTMLCanvasElementModuleTest.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/offscreencanvas/OffscreenCanvas.h View 2 chunks +4 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/modules/offscreencanvas/OffscreenCanvas.cpp View 4 chunks +2 lines, -19 lines 0 comments Download
M third_party/WebKit/Source/modules/offscreencanvas/OffscreenCanvas.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
xidachen
Created Revert of Make OffscreenCanvas Transferable
4 years, 8 months ago (2016-04-21 16:46:18 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1904973003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1904973003/1
4 years, 8 months ago (2016-04-21 16:46:44 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-21 16:47:37 UTC) #4
haraken
LGTM
4 years, 8 months ago (2016-04-21 17:20:56 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:35:20 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bd6b09d886a2a9dcfe4f032df890a4916e35f77e
Cr-Commit-Position: refs/heads/master@{#388790}

Powered by Google App Engine
This is Rietveld 408576698