|
|
Created:
4 years, 8 months ago by Patti Lor Modified:
4 years, 7 months ago Reviewers:
Robert Sesek, sdefresne CC:
chrome-apps-syd-reviews_chromium.org, chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionDocumentation: Update iOS build docs to include instructions for gn.
Committed: https://crrev.com/88a0fac96baac964ac25fff53a05e7b8a3503c0a
Cr-Commit-Position: refs/heads/master@{#390250}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Advise setting target_os instead of use_ios_simulator. #
Created: 4 years, 8 months ago
Messages
Total messages: 14 (5 generated)
Patchset #2 (id:20001) has been deleted
patricialor@chromium.org changed reviewers: + rsesek@chromium.org
PTAL Robert - updated the docs because it took me a while to find the right GN flags to set for an iOS build.
rsesek@chromium.org changed reviewers: + sdefresne@chromium.org
-> sdefresne
https://codereview.chromium.org/1904773003/diff/1/docs/ios_build_instructions.md File docs/ios_build_instructions.md (right): https://codereview.chromium.org/1904773003/diff/1/docs/ios_build_instructions... docs/ios_build_instructions.md:54: use_ios_simulator = true This is not required as the value of use_ios_simulator is automatically initialized from target_cpu on iOS. I usually tweak the following settings on iOS: ios_enable_code_signing = false is_debug = true target_os = "ios" target_cpu = "x64" Then is_debug control release/debug while target_cpu can take the values "x86", "x64", "arm", "armv7" or "arm64". The first two implies simulator build, the last one implies device build. ios_enable_code_signing should be set to false if you do not have valid code signing key.
Thanks Sylvain, PTAL! https://codereview.chromium.org/1904773003/diff/1/docs/ios_build_instructions.md File docs/ios_build_instructions.md (right): https://codereview.chromium.org/1904773003/diff/1/docs/ios_build_instructions... docs/ios_build_instructions.md:54: use_ios_simulator = true On 2016/04/22 15:22:37, sdefresne wrote: > This is not required as the value of use_ios_simulator is automatically > initialized from target_cpu on iOS. > I usually tweak the following settings on iOS: > > ios_enable_code_signing = false > is_debug = true > target_os = "ios" > target_cpu = "x64" > > Then is_debug control release/debug while target_cpu can take the values "x86", > "x64", "arm", "armv7" or "arm64". The first two implies simulator build, the > last one implies device build. ios_enable_code_signing should be set to false if > you do not have valid code signing key. Done, thanks for the extra information!
lgtm
Thank you for keeping the documentation up-to-date and relevant!
The CQ bit was checked by patricialor@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1904773003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1904773003/40001
Message was sent while issue was closed.
Committed patchset #2 (id:40001)
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/88a0fac96baac964ac25fff53a05e7b8a3503c0a Cr-Commit-Position: refs/heads/master@{#390250}
Message was sent while issue was closed.
Description was changed from ========== Documentation: Update iOS build docs to include instructions for gn. ========== to ========== Documentation: Update iOS build docs to include instructions for gn. Committed: https://crrev.com/88a0fac96baac964ac25fff53a05e7b8a3503c0a Cr-Commit-Position: refs/heads/master@{#390250} ========== |