Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 1904773003: Documentation: Update iOS build docs to include instructions for gn. (Closed)

Created:
4 years, 8 months ago by Patti Lor
Modified:
4 years, 7 months ago
Reviewers:
Robert Sesek, sdefresne
CC:
chrome-apps-syd-reviews_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Documentation: Update iOS build docs to include instructions for gn. Committed: https://crrev.com/88a0fac96baac964ac25fff53a05e7b8a3503c0a Cr-Commit-Position: refs/heads/master@{#390250}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Advise setting target_os instead of use_ios_simulator. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -3 lines) Patch
M docs/ios_build_instructions.md View 1 4 chunks +27 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
Patti Lor
PTAL Robert - updated the docs because it took me a while to find the ...
4 years, 8 months ago (2016-04-22 01:49:18 UTC) #3
Robert Sesek
-> sdefresne
4 years, 8 months ago (2016-04-22 15:17:39 UTC) #5
sdefresne
https://codereview.chromium.org/1904773003/diff/1/docs/ios_build_instructions.md File docs/ios_build_instructions.md (right): https://codereview.chromium.org/1904773003/diff/1/docs/ios_build_instructions.md#newcode54 docs/ios_build_instructions.md:54: use_ios_simulator = true This is not required as the ...
4 years, 8 months ago (2016-04-22 15:22:37 UTC) #6
Patti Lor
Thanks Sylvain, PTAL! https://codereview.chromium.org/1904773003/diff/1/docs/ios_build_instructions.md File docs/ios_build_instructions.md (right): https://codereview.chromium.org/1904773003/diff/1/docs/ios_build_instructions.md#newcode54 docs/ios_build_instructions.md:54: use_ios_simulator = true On 2016/04/22 15:22:37, ...
4 years, 8 months ago (2016-04-26 00:03:02 UTC) #7
sdefresne
lgtm
4 years, 7 months ago (2016-04-27 12:44:00 UTC) #8
sdefresne
Thank you for keeping the documentation up-to-date and relevant!
4 years, 7 months ago (2016-04-27 12:44:17 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1904773003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1904773003/40001
4 years, 7 months ago (2016-04-27 23:40:06 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 7 months ago (2016-04-28 00:16:54 UTC) #12
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:14:53 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/88a0fac96baac964ac25fff53a05e7b8a3503c0a
Cr-Commit-Position: refs/heads/master@{#390250}

Powered by Google App Engine
This is Rietveld 408576698