Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2411)

Unified Diff: docs/ios_build_instructions.md

Issue 1904773003: Documentation: Update iOS build docs to include instructions for gn. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Advise setting target_os instead of use_ios_simulator. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: docs/ios_build_instructions.md
diff --git a/docs/ios_build_instructions.md b/docs/ios_build_instructions.md
index d609e944ec22d2eac61fa90f423bde0331662c7f..bfbdc751d1a35c65ed2d310c30edb8355e1f4119 100644
--- a/docs/ios_build_instructions.md
+++ b/docs/ios_build_instructions.md
@@ -16,6 +16,8 @@ the web layer), and various unit tests.
## Setting Up
+### With GYP
+
In the directory where you are going to check out the code, create a
`chromium.gyp_env` to set the build to use iOS targets (and to use
hybrid builds; see [Building](#Building) below):
@@ -41,6 +43,26 @@ cat > chromium.gyp_env <<EOF
EOF
```
+### With GN
+
+Use `gn args out/Debug-iphonesimulator` (or replace
+`out/Debug-iphonesimulator` with your chosen `out/` directory) to open up an
+editor to set the following gn variables and regenerate:
+
+```
+# Set to true if you have a valid code signing key.
+ios_enable_code_signing = false
+target_os = "ios"
+# Set to "x86", "x64", "arm", "armv7", "arm64". "x86" and "x64" will create a
+# build to run on the iOS simulator (and set use_ios_simulator = true), all
+# others are for an iOS device.
+target_cpu = "x64"
+# Release vs debug build.
+is_debug = true
+```
+
+### API Keys
+
Before you build, you may want to
[install API keys](https://sites.google.com/a/chromium.org/dev/developers/how-tos/api-keys)
so that Chrome-integrated Google services work. This step is optional if you
@@ -100,9 +122,9 @@ below:
1. Add `target_os = [ "ios" ]` to the bottom of your `chromium/.gclient`
file.
-2. Make sure you have the following in your `chromium/chromium.gyp_env`
-file (removing the `chromium_ios_signing=0` if you want to make
-developer-signed builds):
+2. For gyp, make sure you have the following in your
+`chromium/chromium.gyp_env` file (removing the `chromium_ios_signing=0` if you
+want to make developer-signed builds):
```json
{
@@ -111,6 +133,8 @@ developer-signed builds):
}
```
+ For gn, add the arguments specified [above](#With-GN) to your gn setup.
+
3. Make sure to sync again to fetch the iOS specific dependencies and
regenerate build rules using:
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698