Move v0 things from ShadowRootRareData into ShadowRootRareDataV0

Move v0 things from ShadowRootRareData into ShadowRootRareDataV0

It is uncomfortable that we are mixing data for v0 and v1 in one place, ShadowRoot (and ShadowRootRareData).
It is nice to separate them cleanly.

This CL introduces ShadowRootRareDavaV0 and move some of data into it.
I'll do another clean up in follow-up CLs, moving some of data in ShadowRoot into ShadowRootRareDataV0.

BUG=531990
Committed: https://crrev.com/a457c140f456055a5d9fda5bea4d2741d9e2cb6d
Cr-Commit-Position: refs/heads/master@{#388718}

[hayato, 2016-04-20 13:54:53]

The CQ bit was checked by hayato@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-20 13:55:10]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1904703002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1904703002/1

[commit-bot: I haz the power, 2016-04-20 15:14:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-20 15:14:23]

Dry run: This issue passed the CQ dry run.

[hayato, 2016-04-21 05:12:09]

Description was changed from

==========
Separete ShadowRootRareData

BUG=
==========

to

==========
Move v0 things from ShadowRootRareData into ShadowRareDataV0

It is uncomfortable that we are mixing data for v0 and v1 in one place,
ShadowRoot (and ShadowRootRareData).
It is nice to separate them cleanly.

This CL introduces ShadowRareDavaV0 and move some of data into it.
I'll do another clean up in other CLs, moving some of data in ShadowRoot into
ShadowRootRareDataV0.

BUG=531990
==========

[hayato, 2016-04-21 05:12:26]

Description was changed from

==========
Move v0 things from ShadowRootRareData into ShadowRareDataV0

It is uncomfortable that we are mixing data for v0 and v1 in one place,
ShadowRoot (and ShadowRootRareData).
It is nice to separate them cleanly.

This CL introduces ShadowRareDavaV0 and move some of data into it.
I'll do another clean up in other CLs, moving some of data in ShadowRoot into
ShadowRootRareDataV0.

BUG=531990
==========

to

==========
Move v0 things from ShadowRootRareData into ShadowRootRareDataV0

It is uncomfortable that we are mixing data for v0 and v1 in one place,
ShadowRoot (and ShadowRootRareData).
It is nice to separate them cleanly.

This CL introduces ShadowRareDavaV0 and move some of data into it.
I'll do another clean up in other CLs, moving some of data in ShadowRoot into
ShadowRootRareDataV0.

BUG=531990
==========

[hayato, 2016-04-21 05:13:34]

hayato@chromium.org changed reviewers:
+ kochi@chromium.org, tkent@chromium.org

[hayato, 2016-04-21 05:13:35]

PTAL

[hayato, 2016-04-21 05:14:05]

Description was changed from

==========
Move v0 things from ShadowRootRareData into ShadowRootRareDataV0

It is uncomfortable that we are mixing data for v0 and v1 in one place,
ShadowRoot (and ShadowRootRareData).
It is nice to separate them cleanly.

This CL introduces ShadowRareDavaV0 and move some of data into it.
I'll do another clean up in other CLs, moving some of data in ShadowRoot into
ShadowRootRareDataV0.

BUG=531990
==========

to

==========
Move v0 things from ShadowRootRareData into ShadowRootRareDataV0

It is uncomfortable that we are mixing data for v0 and v1 in one place,
ShadowRoot (and ShadowRootRareData).
It is nice to separate them cleanly.

This CL introduces ShadowRootRareDavaV0 and move some of data into it.
I'll do another clean up in follow-up CLs, moving some of data in ShadowRoot
into ShadowRootRareDataV0.

BUG=531990
==========

[kochi, 2016-04-21 05:43:35]

You also need to add 'ShadowRootRareDataV0.h' in
Source/core/core.gypi.

[tkent, 2016-04-21 05:46:01]

https://codereview.chromium.org/1904703002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/dom/shadow/ShadowRoot.cpp (right):

https://codereview.chromium.org/1904703002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/shadow/ShadowRoot.cpp:59: ,
m_shadowRootRareData(nullptr)
You don't need to initialize Member<T> with nullptr.  It's ensured by
Member<T>() constructor.

https://codereview.chromium.org/1904703002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/shadow/ShadowRoot.cpp:211: return
m_shadowRootRareDataV0 ? m_shadowRootRareDataV0->containsShadowElements() : 0;
0 -> false?

https://codereview.chromium.org/1904703002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/shadow/ShadowRoot.cpp:216: return
m_shadowRootRareDataV0 ? m_shadowRootRareDataV0->containsContentElements() : 0;
0 -> false?

https://codereview.chromium.org/1904703002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/shadow/ShadowRoot.cpp:231: return
m_shadowRootRareDataV0 ?
m_shadowRootRareDataV0->shadowInsertionPointOfYoungerShadowRoot() : 0;
0 -> nullptr?

[hayato, 2016-04-21 06:32:39]

The CQ bit was checked by hayato@chromium.org to run a CQ dry run

[hayato, 2016-04-21 06:32:42]

fixed

[commit-bot: I haz the power, 2016-04-21 06:32:56]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1904703002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1904703002/20001

[hayato, 2016-04-21 06:33:28]

core.gypi is updated.

https://codereview.chromium.org/1904703002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/dom/shadow/ShadowRoot.cpp (right):

https://codereview.chromium.org/1904703002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/shadow/ShadowRoot.cpp:59: ,
m_shadowRootRareData(nullptr)
Done

https://codereview.chromium.org/1904703002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/shadow/ShadowRoot.cpp:211: return
m_shadowRootRareDataV0 ? m_shadowRootRareDataV0->containsShadowElements() : 0;
Done

https://codereview.chromium.org/1904703002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/shadow/ShadowRoot.cpp:216: return
m_shadowRootRareDataV0 ? m_shadowRootRareDataV0->containsContentElements() : 0;
Done

https://codereview.chromium.org/1904703002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/shadow/ShadowRoot.cpp:231: return
m_shadowRootRareDataV0 ?
m_shadowRootRareDataV0->shadowInsertionPointOfYoungerShadowRoot() : 0;
Done

[tkent, 2016-04-21 06:37:05]

lgtm

[hayato, 2016-04-21 07:07:06]

The CQ bit was unchecked by hayato@chromium.org

[hayato, 2016-04-21 07:07:10]

The CQ bit was checked by hayato@chromium.org

[commit-bot: I haz the power, 2016-04-21 07:07:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1904703002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1904703002/20001

[commit-bot: I haz the power, 2016-04-21 08:07:11]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-22 19:32:28]

Description was changed from

==========
Move v0 things from ShadowRootRareData into ShadowRootRareDataV0

It is uncomfortable that we are mixing data for v0 and v1 in one place,
ShadowRoot (and ShadowRootRareData).
It is nice to separate them cleanly.

This CL introduces ShadowRootRareDavaV0 and move some of data into it.
I'll do another clean up in follow-up CLs, moving some of data in ShadowRoot
into ShadowRootRareDataV0.

BUG=531990
==========

to

==========
Move v0 things from ShadowRootRareData into ShadowRootRareDataV0

It is uncomfortable that we are mixing data for v0 and v1 in one place,
ShadowRoot (and ShadowRootRareData).
It is nice to separate them cleanly.

This CL introduces ShadowRootRareDavaV0 and move some of data into it.
I'll do another clean up in follow-up CLs, moving some of data in ShadowRoot
into ShadowRootRareDataV0.

BUG=531990

Committed: https://crrev.com/a457c140f456055a5d9fda5bea4d2741d9e2cb6d
Cr-Commit-Position: refs/heads/master@{#388718}
==========

[commit-bot: I haz the power, 2016-04-22 19:32:29]

Patchset 2 (id:??) landed as
https://crrev.com/a457c140f456055a5d9fda5bea4d2741d9e2cb6d
Cr-Commit-Position: refs/heads/master@{#388718}