Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(469)

Issue 1904923002: Reduce a shadow root object's size by not inheriting DoublyLinkedList (Closed)

Created:
4 years, 8 months ago by hayato
Modified:
4 years, 8 months ago
Reviewers:
tkent, kochi
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof, webcomponents-bugzilla_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@raredatav0
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reduce a shadow root object's size by not inheriting DoublyLinkedList Using DoublyLinkedList increases a shadow root object's size by adding two pointers, m_prev and m_next. Because these pointers are only required for multiple shadow roots, these pointers can be moved to ShadowRootRareDataV0. - Maintain a doubly linked list manually, instead of inheriting DoublyLinkedList. - ElementShadow has only one shadowRoot object, instead of having DoublyLinkedList<ShadowRoot>. - ElementShadow::m_shadowRoot acts as the oldest shadow root in case for multiple shadow roots. BUG=531990 Committed: https://crrev.com/c47ae70a879d7247c56a842716f4ab67ac25a71d Cr-Commit-Position: refs/heads/master@{#389013}

Patch Set 1 #

Total comments: 6

Patch Set 2 : use DCHECK_EQ #

Patch Set 3 : fix typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -49 lines) Patch
M third_party/WebKit/Source/core/dom/shadow/ElementShadow.h View 4 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/dom/shadow/ElementShadow.cpp View 1 3 chunks +31 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/dom/shadow/ShadowRoot.h View 6 chunks +8 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/core/dom/shadow/ShadowRoot.cpp View 1 2 10 chunks +40 lines, -19 lines 0 comments Download
M third_party/WebKit/Source/core/dom/shadow/ShadowRootRareDataV0.h View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 42 (23 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1904923002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1904923002/1
4 years, 8 months ago (2016-04-21 07:19:20 UTC) #2
hayato
PTAL
4 years, 8 months ago (2016-04-21 07:32:40 UTC) #10
tkent
lgtm https://codereview.chromium.org/1904923002/diff/1/third_party/WebKit/Source/core/dom/shadow/ElementShadow.cpp File third_party/WebKit/Source/core/dom/shadow/ElementShadow.cpp (right): https://codereview.chromium.org/1904923002/diff/1/third_party/WebKit/Source/core/dom/shadow/ElementShadow.cpp#newcode162 third_party/WebKit/Source/core/dom/shadow/ElementShadow.cpp:162: DCHECK(m_shadowRoot->type() == ShadowRootType::V0); DCHECK -> DCHECK_EQ https://codereview.chromium.org/1904923002/diff/1/third_party/WebKit/Source/core/dom/shadow/ShadowRoot.cpp File ...
4 years, 8 months ago (2016-04-21 07:43:00 UTC) #12
hayato
use DCHECK_EQ
4 years, 8 months ago (2016-04-21 07:45:42 UTC) #14
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1904923002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1904923002/20001
4 years, 8 months ago (2016-04-21 07:45:46 UTC) #15
hayato
Ops. I forgot that you added "operater<<" for ShadowRootType. Nice. https://codereview.chromium.org/1904923002/diff/1/third_party/WebKit/Source/core/dom/shadow/ElementShadow.cpp File third_party/WebKit/Source/core/dom/shadow/ElementShadow.cpp (right): https://codereview.chromium.org/1904923002/diff/1/third_party/WebKit/Source/core/dom/shadow/ElementShadow.cpp#newcode162 ...
4 years, 8 months ago (2016-04-21 07:47:49 UTC) #16
commit-bot: I haz the power
This CL has an open dependency (Issue 1904703002 Patch 20001). Please resolve the dependency and ...
4 years, 8 months ago (2016-04-21 07:48:23 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1904923002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1904923002/20001
4 years, 8 months ago (2016-04-21 08:07:56 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_compile_dbg_ng/builds/188814) linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, ...
4 years, 8 months ago (2016-04-21 08:08:35 UTC) #25
hayato
fix typo
4 years, 8 months ago (2016-04-21 08:43:18 UTC) #27
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1904923002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1904923002/40001
4 years, 8 months ago (2016-04-21 08:43:28 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1904923002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1904923002/40001
4 years, 8 months ago (2016-04-21 08:43:51 UTC) #32
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/148445) linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED, ...
4 years, 8 months ago (2016-04-21 08:48:16 UTC) #34
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1904923002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1904923002/40001
4 years, 8 months ago (2016-04-22 02:19:32 UTC) #36
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-04-22 03:50:44 UTC) #37
kochi
lgtm BTW, ShadowRoot/ElementShadow was the only user of wtf/DoublyLinkedList, so if the usage is gone ...
4 years, 8 months ago (2016-04-22 04:54:31 UTC) #38
tkent
> BTW, ShadowRoot/ElementShadow was the only user of > wtf/DoublyLinkedList, so if the usage is ...
4 years, 8 months ago (2016-04-22 05:18:06 UTC) #39
kochi
On 2016/04/22 05:18:06, tkent wrote: > > BTW, ShadowRoot/ElementShadow was the only user of > ...
4 years, 8 months ago (2016-04-22 06:54:59 UTC) #40
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:43:49 UTC) #42
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/c47ae70a879d7247c56a842716f4ab67ac25a71d
Cr-Commit-Position: refs/heads/master@{#389013}

Powered by Google App Engine
This is Rietveld 408576698