Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 1904683002: Move the m_didTransformToRootUpdate flag to LayoutSVGContainer (Closed)

Created:
4 years, 8 months ago by fs
Modified:
4 years, 8 months ago
Reviewers:
pdr., Stephen Chennney
CC:
fs, blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, krit, eae+blinkwatch, f(malita), gyuyoung2, jchaffraix+rendering, kouhei+svg_chromium.org, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move the m_didTransformToRootUpdate flag to LayoutSVGContainer By pushing the update of the m_didTransformToRootUpdate flag out of the various calculateLocalTransform() implementations, we both get implementations of those methods that are more to the point, and expose the redundant calls to SVGLayoutSupport::transformToRootChanged(). This also means that didTransformToRootUpdate() is devirtualized, although it was never called "virtually" before either. Also turn m_needsBoundariesUpdate into a single-bit flag. BUG=603956 Committed: https://crrev.com/641397ee2d4f59b3249329030d96a2177c918db1 Cr-Commit-Position: refs/heads/master@{#388516}

Patch Set 1 #

Messages

Total messages: 9 (4 generated)
fs
4 years, 8 months ago (2016-04-20 13:08:08 UTC) #2
Stephen Chennney
lgtm
4 years, 8 months ago (2016-04-20 16:23:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1904683002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1904683002/1
4 years, 8 months ago (2016-04-20 16:28:13 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-20 16:32:20 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:24:10 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/641397ee2d4f59b3249329030d96a2177c918db1
Cr-Commit-Position: refs/heads/master@{#388516}

Powered by Google App Engine
This is Rietveld 408576698