Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 1904613002: Preparation patch for moving the chrome crashpad integration into chrome_elf. (Closed)

Created:
4 years, 8 months ago by ananta
Modified:
4 years, 8 months ago
CC:
chromium-reviews, native-client-reviews_googlegroups.com, caitkp+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Preparation patch for moving the chrome crashpad integration into chrome_elf. Changes in this patch as below : 1. Moved the ChromeCrashReporterClient class on Windows to chrome/app/chrome_crash_reporter_client_win.cc/.h These files still contain common code from chrome_crash_reporter_client.cc/.h. Will fix this in an upcoming patch. 2. Use the chrome_crash_reporter_client_win.cc/.h on Windows. 3. Moved the chrome_elf_util.cc/.h files to a new target chrome/install_static. These files have been renamed to install_util.cc/.h. The new target install_static_util is a static library and is currently lined with chrome_elf and related targets. 4. Used the install_static_util target in chrome_elf targets. BUG=604923 Committed: https://crrev.com/0a700e23869fd67a39b24a556a0232b1bafaaa5e Cr-Commit-Position: refs/heads/master@{#388666}

Patch Set 1 #

Patch Set 2 : Fix indent #

Total comments: 4

Patch Set 3 : Fix review comments #

Patch Set 4 : Rebased to tip #

Patch Set 5 : Add chrome_crash_reporter_client_win.cc/.h #

Patch Set 6 : Add chrome_installer_static.gypi #

Total comments: 4

Patch Set 7 : Address sky's review comments #

Total comments: 6

Patch Set 8 : Address robertshield's review comments #

Patch Set 9 : Add an include guard for !OS_WIN in chrome_crash_reporter_client.h and fix build error for nacl #

Total comments: 8

Patch Set 10 : Fix indentation #

Patch Set 11 : Fix build error on Windows builder #

Unified diffs Side-by-side diffs Delta from patch set Stats (+197 lines, -677 lines) Patch
M chrome/BUILD.gn View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/app/chrome_crash_reporter_client.h View 1 2 3 4 5 6 7 8 4 chunks +6 lines, -27 lines 0 comments Download
M chrome/app/chrome_crash_reporter_client.cc View 1 2 3 3 chunks +1 line, -220 lines 0 comments Download
A + chrome/app/chrome_crash_reporter_client_win.h View 1 2 3 4 4 chunks +4 lines, -25 lines 0 comments Download
A + chrome/app/chrome_crash_reporter_client_win.cc View 1 2 3 4 5 6 7 8 9 10 8 chunks +13 lines, -100 lines 0 comments Download
M chrome/app/chrome_exe_main_win.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/chrome_main_delegate.cc View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M chrome/app/main_dll_loader_win.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/process_singleton_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome.gyp View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/chrome_exe.gypi View 1 2 3 4 5 6 7 8 2 chunks +3 lines, -3 lines 0 comments Download
A chrome/chrome_installer_static.gypi View 1 2 3 4 5 6 7 8 9 1 chunk +83 lines, -0 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A chrome/install_static/BUILD.gn View 1 2 3 4 5 6 7 1 chunk +38 lines, -0 lines 0 comments Download
A + chrome/install_static/install_util.h View 1 2 3 4 5 6 7 2 chunks +8 lines, -4 lines 0 comments Download
A + chrome/install_static/install_util.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/nacl/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M chrome/nacl/nacl_exe_win_64.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/BUILD.gn View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/chrome_test_launcher.cc View 1 2 3 4 5 6 1 chunk +5 lines, -1 line 0 comments Download
M chrome_elf/BUILD.gn View 1 2 3 6 chunks +5 lines, -2 lines 0 comments Download
M chrome_elf/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M chrome_elf/blacklist/blacklist.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome_elf/blacklist/test/blacklist_test_main_dll.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome_elf/breakpad.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome_elf/chrome_elf.gyp View 1 2 5 chunks +4 lines, -2 lines 0 comments Download
M chrome_elf/chrome_elf_main.cc View 1 chunk +4 lines, -3 lines 0 comments Download
D chrome_elf/chrome_elf_util.h View 1 chunk +0 lines, -44 lines 0 comments Download
D chrome_elf/chrome_elf_util.cc View 1 chunk +0 lines, -224 lines 0 comments Download
M chrome_elf/chrome_elf_util_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M components/nacl/broker/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 29 (12 generated)
ananta
4 years, 8 months ago (2016-04-19 23:17:04 UTC) #2
scottmg
This seems good to me, I don't own anything here though. https://codereview.chromium.org/1904613002/diff/20001/chrome/install_static/BUILD.gn File chrome/install_static/BUILD.gn (right): ...
4 years, 8 months ago (2016-04-19 23:27:17 UTC) #3
ananta
https://codereview.chromium.org/1904613002/diff/20001/chrome/install_static/BUILD.gn File chrome/install_static/BUILD.gn (right): https://codereview.chromium.org/1904613002/diff/20001/chrome/install_static/BUILD.gn#newcode28 chrome/install_static/BUILD.gn:28: "advapi32.lib", On 2016/04/19 23:27:17, scottmg wrote: > This is ...
4 years, 8 months ago (2016-04-19 23:42:43 UTC) #4
ananta
+sky for src\chrome +robertshield for src\chrome_elf
4 years, 8 months ago (2016-04-19 23:47:23 UTC) #6
sky
LGTM https://codereview.chromium.org/1904613002/diff/100001/chrome/app/chrome_crash_reporter_client_win.h File chrome/app/chrome_crash_reporter_client_win.h (left): https://codereview.chromium.org/1904613002/diff/100001/chrome/app/chrome_crash_reporter_client_win.h#oldcode21 chrome/app/chrome_crash_reporter_client_win.h:21: class ChromeCrashReporterClient : public crash_reporter::CrashReporterClient { I think ...
4 years, 8 months ago (2016-04-20 02:15:23 UTC) #7
sky
Also, can you get a local OWNER for nacl please?
4 years, 8 months ago (2016-04-20 02:15:50 UTC) #8
robertshield
https://codereview.chromium.org/1904613002/diff/120001/chrome/chrome_installer_static.gypi File chrome/chrome_installer_static.gypi (right): https://codereview.chromium.org/1904613002/diff/120001/chrome/chrome_installer_static.gypi#newcode11 chrome/chrome_installer_static.gypi:11: # This part is shared between the two versions ...
4 years, 8 months ago (2016-04-20 17:32:50 UTC) #9
ananta
https://codereview.chromium.org/1904613002/diff/100001/chrome/app/chrome_crash_reporter_client_win.h File chrome/app/chrome_crash_reporter_client_win.h (left): https://codereview.chromium.org/1904613002/diff/100001/chrome/app/chrome_crash_reporter_client_win.h#oldcode21 chrome/app/chrome_crash_reporter_client_win.h:21: class ChromeCrashReporterClient : public crash_reporter::CrashReporterClient { On 2016/04/20 02:15:22, ...
4 years, 8 months ago (2016-04-20 20:15:36 UTC) #10
ananta
+sehr for nacl owners
4 years, 8 months ago (2016-04-20 22:02:05 UTC) #12
robertshield
LGTM w/indent nits https://codereview.chromium.org/1904613002/diff/160001/chrome/chrome_installer_static.gypi File chrome/chrome_installer_static.gypi (right): https://codereview.chromium.org/1904613002/diff/160001/chrome/chrome_installer_static.gypi#newcode41 chrome/chrome_installer_static.gypi:41: # Please don't add dependencies on ...
4 years, 8 months ago (2016-04-21 00:18:31 UTC) #13
Derek Schuff
chrome/nacl LGTM
4 years, 8 months ago (2016-04-21 00:26:00 UTC) #15
ananta
https://codereview.chromium.org/1904613002/diff/160001/chrome/chrome_installer_static.gypi File chrome/chrome_installer_static.gypi (right): https://codereview.chromium.org/1904613002/diff/160001/chrome/chrome_installer_static.gypi#newcode41 chrome/chrome_installer_static.gypi:41: # Please don't add dependencies on other system libraries. ...
4 years, 8 months ago (2016-04-21 00:33:47 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1904613002/180001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1904613002/180001
4 years, 8 months ago (2016-04-21 00:35:30 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/216083) win8_chromium_ng on tryserver.chromium.win (JOB_FAILED, ...
4 years, 8 months ago (2016-04-21 01:16:20 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1904613002/200001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1904613002/200001
4 years, 8 months ago (2016-04-21 01:35:44 UTC) #26
commit-bot: I haz the power
Committed patchset #11 (id:200001)
4 years, 8 months ago (2016-04-21 03:00:59 UTC) #27
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:30:33 UTC) #29
Message was sent while issue was closed.
Patchset 11 (id:??) landed as
https://crrev.com/0a700e23869fd67a39b24a556a0232b1bafaaa5e
Cr-Commit-Position: refs/heads/master@{#388666}

Powered by Google App Engine
This is Rietveld 408576698