Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Unified Diff: chrome/app/chrome_crash_reporter_client_win.h

Issue 1904613002: Preparation patch for moving the chrome crashpad integration into chrome_elf. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix build error on Windows builder Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/app/chrome_crash_reporter_client.cc ('k') | chrome/app/chrome_crash_reporter_client_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/app/chrome_crash_reporter_client_win.h
diff --git a/chrome/app/chrome_crash_reporter_client.h b/chrome/app/chrome_crash_reporter_client_win.h
similarity index 73%
copy from chrome/app/chrome_crash_reporter_client.h
copy to chrome/app/chrome_crash_reporter_client_win.h
index 4d184861175fdbffa51c485f8cb410e2e64fb8aa..7fcec6df364b837d99126b47d73972dc8c20358b 100644
--- a/chrome/app/chrome_crash_reporter_client.h
+++ b/chrome/app/chrome_crash_reporter_client_win.h
@@ -1,12 +1,11 @@
-// Copyright 2013 The Chromium Authors. All rights reserved.
+// Copyright 2016 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef CHROME_APP_CHROME_CRASH_REPORTER_CLIENT_H_
-#define CHROME_APP_CHROME_CRASH_REPORTER_CLIENT_H_
+#ifndef CHROME_APP_CHROME_CRASH_REPORTER_CLIENT_WIN_H_
+#define CHROME_APP_CHROME_CRASH_REPORTER_CLIENT_WIN_H_
#include <stddef.h>
-
#include <memory>
#include "base/compiler_specific.h"
@@ -24,11 +23,6 @@ class ChromeCrashReporterClient : public crash_reporter::CrashReporterClient {
~ChromeCrashReporterClient() override;
// crash_reporter::CrashReporterClient implementation.
-#if !defined(OS_MACOSX) && !defined(OS_WIN)
- void SetCrashReporterClientIdFromGUID(
- const std::string& client_guid) override;
-#endif
-#if defined(OS_WIN)
bool GetAlternativeCrashDumpLocation(base::FilePath* crash_dir) override;
void GetProductNameAndVersion(const base::FilePath& exe_path,
base::string16* product_name,
@@ -47,13 +41,6 @@ class ChromeCrashReporterClient : public crash_reporter::CrashReporterClient {
void RecordCrashDumpAttempt(bool is_real_crash) override;
void RecordCrashDumpAttemptResult(bool is_real_crash,
bool succeeded) override;
-#endif
-
-#if defined(OS_POSIX) && !defined(OS_MACOSX)
- void GetProductNameAndVersion(const char** product_name,
- const char** version) override;
- base::FilePath GetReporterLogFilename() override;
-#endif
bool GetCrashDumpLocation(base::FilePath* crash_dir) override;
@@ -63,23 +50,15 @@ class ChromeCrashReporterClient : public crash_reporter::CrashReporterClient {
bool GetCollectStatsConsent() override;
-#if defined(OS_WIN) || defined(OS_MACOSX)
bool ReportingIsEnforcedByPolicy(bool* breakpad_enabled) override;
-#endif
-
-#if defined(OS_ANDROID)
- int GetAndroidMinidumpDescriptor() override;
-#endif
bool EnableBreakpadForProcess(const std::string& process_type) override;
private:
-#if defined(OS_WIN)
std::unique_ptr<browser_watcher::CrashReportingMetrics>
crash_reporting_metrics_;
-#endif
DISALLOW_COPY_AND_ASSIGN(ChromeCrashReporterClient);
};
-#endif // CHROME_APP_CHROME_CRASH_REPORTER_CLIENT_H_
+#endif // CHROME_APP_CHROME_CRASH_REPORTER_CLIENT_WIN_H_
« no previous file with comments | « chrome/app/chrome_crash_reporter_client.cc ('k') | chrome/app/chrome_crash_reporter_client_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698