Fix strong mode errors in dart:io.

Fix strong mode errors in dart:io.

Still a lot of strong mode warnings left.

R=fschneider@google.com, sgjesse@google.com

Committed: https://github.com/dart-lang/sdk/commit/5216f1d67d09d289f7c7ceab56a64ce0dcb7d563

Reverted: https://github.com/dart-lang/sdk/commit/7503ecc8fdb32747b2b05b529219ce83da8f0b6c

Committed: https://github.com/dart-lang/sdk/commit/e3c3f099ea6d36c244f93c30d95abd43a2f67649

[floitsch, 2016-05-04 13:59:13]

floitsch@google.com changed reviewers:
+ sgjesse@google.com

[floitsch, 2016-05-04 13:59:15]

https://codereview.chromium.org/1904553006/diff/80001/runtime/bin/directory.cc
File runtime/bin/directory.cc (right):

https://codereview.chromium.org/1904553006/diff/80001/runtime/bin/directory.c...
runtime/bin/directory.cc:118: void
FUNCTION_NAME(Directory_FillWithDirectoryListing)(
I can live with the name, but if you have a better/shorter one, I would be happy
to change it.

[Søren Gjesse, 2016-05-04 16:14:10]

LGTM, thanks

https://codereview.chromium.org/1904553006/diff/80001/sdk/lib/io/http_impl.dart
File sdk/lib/io/http_impl.dart (right):

https://codereview.chromium.org/1904553006/diff/80001/sdk/lib/io/http_impl.da...
sdk/lib/io/http_impl.dart:195: X509Certificate get certificate {
Maybe add an is-check to throw a better exception?

[floitsch, 2016-05-04 18:28:41]

https://codereview.chromium.org/1904553006/diff/80001/sdk/lib/io/http_impl.dart
File sdk/lib/io/http_impl.dart (right):

https://codereview.chromium.org/1904553006/diff/80001/sdk/lib/io/http_impl.da...
sdk/lib/io/http_impl.dart:195: X509Certificate get certificate {
On 2016/05/04 16:14:09, Søren Gjesse wrote:
> Maybe add an is-check to throw a better exception?

Done.

[Florian Schneider, 2016-05-09 09:05:14]

fschneider@google.com changed reviewers:
+ fschneider@google.com

[Florian Schneider, 2016-05-09 09:05:15]

https://codereview.chromium.org/1904553006/diff/100001/runtime/bin/stdio_patc...
File runtime/bin/stdio_patch.dart (right):

https://codereview.chromium.org/1904553006/diff/100001/runtime/bin/stdio_patc...
runtime/bin/stdio_patch.dart:33: if (socket is _Socket) {
Why do the is-test again here?

https://codereview.chromium.org/1904553006/diff/100001/sdk/lib/io/stdio.dart
File sdk/lib/io/stdio.dart (right):

https://codereview.chromium.org/1904553006/diff/100001/sdk/lib/io/stdio.dart#...
sdk/lib/io/stdio.dart:332: if (socketType != null) {
Why is this null-check necessary?

[floitsch, 2016-05-09 12:48:01]

https://codereview.chromium.org/1904553006/diff/100001/runtime/bin/stdio_patc...
File runtime/bin/stdio_patch.dart (right):

https://codereview.chromium.org/1904553006/diff/100001/runtime/bin/stdio_patc...
runtime/bin/stdio_patch.dart:33: if (socket is _Socket) {
On 2016/05/09 09:05:15, Florian Schneider wrote:
> Why do the is-test again here?
> 

Where is the other test?

Basically, `nativeSocket` was guaranteed to be a `_nativeSocket` from a
`_Socket`. The `_nativeSocket` was extracted on the non-patch side, which looked
wrong, since that side shouldn't know about the `_Socket` class (which is
declared in the patch-side).
I changed the signature to take a `Socket` class instead, and check here, if it
really is a `_Socket` instead.

https://codereview.chromium.org/1904553006/diff/100001/sdk/lib/io/stdio.dart
File sdk/lib/io/stdio.dart (right):

https://codereview.chromium.org/1904553006/diff/100001/sdk/lib/io/stdio.dart#...
sdk/lib/io/stdio.dart:332: if (socketType != null) {
On 2016/05/09 09:05:15, Florian Schneider wrote:
> Why is this null-check necessary?

Because it returns `null` if the object is not a `_Socket` (native-socket). If
it is a user-defined `Socket` class, then we end up returning `StdioType.OTHER`.

[Florian Schneider, 2016-05-09 13:39:43]

https://codereview.chromium.org/1904553006/diff/100001/runtime/bin/stdio_patc...
File runtime/bin/stdio_patch.dart (right):

https://codereview.chromium.org/1904553006/diff/100001/runtime/bin/stdio_patc...
runtime/bin/stdio_patch.dart:33: if (socket is _Socket) {
On 2016/05/09 12:48:01, floitsch wrote:
> On 2016/05/09 09:05:15, Florian Schneider wrote:
> > Why do the is-test again here?
> > 
> 
> Where is the other test?
> 
> Basically, `nativeSocket` was guaranteed to be a `_nativeSocket` from a
> `_Socket`. The `_nativeSocket` was extracted on the non-patch side, which
looked
> wrong, since that side shouldn't know about the `_Socket` class (which is
> declared in the patch-side).
> I changed the signature to take a `Socket` class instead, and check here, if
it
> really is a `_Socket` instead.

Sorry, missed the _.

https://codereview.chromium.org/1904553006/diff/100001/sdk/lib/io/stdio.dart
File sdk/lib/io/stdio.dart (right):

https://codereview.chromium.org/1904553006/diff/100001/sdk/lib/io/stdio.dart#...
sdk/lib/io/stdio.dart:332: if (socketType != null) {
On 2016/05/09 12:48:01, floitsch wrote:
> On 2016/05/09 09:05:15, Florian Schneider wrote:
> > Why is this null-check necessary?
> 
> Because it returns `null` if the object is not a `_Socket` (native-socket). If
> it is a user-defined `Socket` class, then we end up returning
`StdioType.OTHER`.
> 

Ok, but in case of null the switch would be skipped anyway?

[floitsch, 2016-05-09 14:21:32]

https://codereview.chromium.org/1904553006/diff/100001/sdk/lib/io/stdio.dart
File sdk/lib/io/stdio.dart (right):

https://codereview.chromium.org/1904553006/diff/100001/sdk/lib/io/stdio.dart#...
sdk/lib/io/stdio.dart:332: if (socketType != null) {
On 2016/05/09 13:39:43, Florian Schneider wrote:
> On 2016/05/09 12:48:01, floitsch wrote:
> > On 2016/05/09 09:05:15, Florian Schneider wrote:
> > > Why is this null-check necessary?
> > 
> > Because it returns `null` if the object is not a `_Socket` (native-socket).
If
> > it is a user-defined `Socket` class, then we end up returning
> `StdioType.OTHER`.
> > 
> 
> Ok, but in case of null the switch would be skipped anyway?

Changed it so that it directly returns StdioType.OTHER.

[Florian Schneider, 2016-05-09 14:24:54]

On 2016/05/09 14:21:32, floitsch wrote:
> https://codereview.chromium.org/1904553006/diff/100001/sdk/lib/io/stdio.dart
> File sdk/lib/io/stdio.dart (right):
> 
>
https://codereview.chromium.org/1904553006/diff/100001/sdk/lib/io/stdio.dart#...
> sdk/lib/io/stdio.dart:332: if (socketType != null) {
> On 2016/05/09 13:39:43, Florian Schneider wrote:
> > On 2016/05/09 12:48:01, floitsch wrote:
> > > On 2016/05/09 09:05:15, Florian Schneider wrote:
> > > > Why is this null-check necessary?
> > > 
> > > Because it returns `null` if the object is not a `_Socket`
(native-socket).
> If
> > > it is a user-defined `Socket` class, then we end up returning
> > `StdioType.OTHER`.
> > > 
> > 
> > Ok, but in case of null the switch would be skipped anyway?
> 
> Changed it so that it directly returns StdioType.OTHER.

Thanks!

[floitsch, 2016-05-09 22:34:01]

Had to fix a test and change the stdio-mode test.
They are minor changes, but if you want, PTAL.
I will commit tomorrow.

[Florian Schneider, 2016-05-10 08:19:10]

Lgtm.

https://codereview.chromium.org/1904553006/diff/120001/runtime/bin/directory.cc
File runtime/bin/directory.cc (right):

https://codereview.chromium.org/1904553006/diff/120001/runtime/bin/directory....
runtime/bin/directory.cc:124: // Create the list to hold the directory listing
here, and pass it to the
This comment is out of date now since the list is passed in as an argument now.

[floitsch, 2016-05-10 13:37:35]

https://codereview.chromium.org/1904553006/diff/120001/runtime/bin/directory.cc
File runtime/bin/directory.cc (right):

https://codereview.chromium.org/1904553006/diff/120001/runtime/bin/directory....
runtime/bin/directory.cc:124: // Create the list to hold the directory listing
here, and pass it to the
On 2016/05/10 08:19:10, Florian Schneider wrote:
> This comment is out of date now since the list is passed in as an argument
now.

I thought I had deleted that comment.
Thanks and done.

[floitsch, 2016-05-11 12:30:37]

Description was changed from

==========
Fix strong mode errors in dart:io.

Still a lot of strong mode warnings left.
==========

to

==========
Fix strong mode errors in dart:io.

Still a lot of strong mode warnings left.

R=fschneider@google.com, sgjesse@google.com

Committed:
https://github.com/dart-lang/sdk/commit/5216f1d67d09d289f7c7ceab56a64ce0dcb7d563
==========

[floitsch, 2016-05-11 12:30:39]

Committed patchset #8 (id:140001) manually as
5216f1d67d09d289f7c7ceab56a64ce0dcb7d563 (presubmit successful).

[floitsch, 2016-05-11 19:46:05]

Description was changed from

==========
Fix strong mode errors in dart:io.

Still a lot of strong mode warnings left.

R=fschneider@google.com, sgjesse@google.com

Committed:
https://github.com/dart-lang/sdk/commit/5216f1d67d09d289f7c7ceab56a64ce0dcb7d563
==========

to

==========
Fix strong mode errors in dart:io.

Still a lot of strong mode warnings left.

R=fschneider@google.com, sgjesse@google.com

Committed:
https://github.com/dart-lang/sdk/commit/5216f1d67d09d289f7c7ceab56a64ce0dcb7d563

Reverted:
https://github.com/dart-lang/sdk/commit/7503ecc8fdb32747b2b05b529219ce83da8f0b6c
==========

[floitsch, 2016-05-11 19:46:48]

Had to revert.
Reopening this issue. Uploaded after a rebase.

[Ivan Posva, 2016-05-11 20:06:47]

On 2016/05/11 19:46:48, floitsch wrote:
> Had to revert.
> Reopening this issue. Uploaded after a rebase.

You will also need to update the Directory_List in directory_unsupported.cc file
so that the Dartium specific build has access to the new native name.

-Ivan

[floitsch, 2016-05-12 11:16:28]

On 2016/05/11 20:06:47, Ivan Posva wrote:
> On 2016/05/11 19:46:48, floitsch wrote:
> > Had to revert.
> > Reopening this issue. Uploaded after a rebase.
> 
> You will also need to update the Directory_List in directory_unsupported.cc
file
> so that the Dartium specific build has access to the new native name.
> 
> -Ivan

Thanks!

[floitsch, 2016-05-12 11:17:03]

Renamed the native function in directory_unsupported.cc.
Landing again.

[floitsch, 2016-05-12 11:17:35]

Description was changed from

==========
Fix strong mode errors in dart:io.

Still a lot of strong mode warnings left.

R=fschneider@google.com, sgjesse@google.com

Committed:
https://github.com/dart-lang/sdk/commit/5216f1d67d09d289f7c7ceab56a64ce0dcb7d563

Reverted:
https://github.com/dart-lang/sdk/commit/7503ecc8fdb32747b2b05b529219ce83da8f0b6c
==========

to

==========
Fix strong mode errors in dart:io.

Still a lot of strong mode warnings left.

R=fschneider@google.com, sgjesse@google.com

Committed:
https://github.com/dart-lang/sdk/commit/5216f1d67d09d289f7c7ceab56a64ce0dcb7d563

Reverted:
https://github.com/dart-lang/sdk/commit/7503ecc8fdb32747b2b05b529219ce83da8f0b6c

Committed:
https://github.com/dart-lang/sdk/commit/e3c3f099ea6d36c244f93c30d95abd43a2f67649
==========

[floitsch, 2016-05-12 11:17:38]

Committed patchset #10 (id:180001) manually as
e3c3f099ea6d36c244f93c30d95abd43a2f67649 (presubmit successful).