Fix strong mode errors in dart:io.

runtime/bin/directory.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #if !defined(DART_IO_DISABLED)
 
 #include "bin/directory.h"
 
 #include "bin/dartutils.h"
 #include "bin/log.h"
@@ skipping 97 matching lines @@
   Dart_Handle newPath = Dart_GetNativeArgument(args, 1);
   if (Directory::Rename(DartUtils::GetStringValue(path),
                         DartUtils::GetStringValue(newPath))) {
     Dart_SetReturnValue(args, Dart_True());
   } else {
     Dart_SetReturnValue(args, DartUtils::NewDartOSError());
   }
 }
 
 
-void FUNCTION_NAME(Directory_List)(Dart_NativeArguments args) {
-  Dart_Handle path = Dart_GetNativeArgument(args, 0);
-  Dart_Handle recursive = Dart_GetNativeArgument(args, 1);
+void FUNCTION_NAME(Directory_FillWithDirectoryListing)(
+    Dart_NativeArguments args) {
+  // The list that we should fill.
+  Dart_Handle results = Dart_GetNativeArgument(args, 0);
+  Dart_Handle path = Dart_GetNativeArgument(args, 1);
+  Dart_Handle recursive = Dart_GetNativeArgument(args, 2);
   // Create the list to hold the directory listing here, and pass it to the

[Florian Schneider, 2016/05/10 08:19:10]

This comment is out of date now since the list is passed in as an argument now.

[floitsch, 2016/05/10 13:37:35]

I thought I had deleted that comment.
Thanks and done.

   // SyncDirectoryListing object, which adds elements to it.
-  Dart_Handle follow_links = Dart_GetNativeArgument(args, 2);
-  // Create the list to hold the directory listing here, and pass it to the
+  Dart_Handle follow_links = Dart_GetNativeArgument(args, 3);
+  // Pass the list that should hold the directory listing to the
   // SyncDirectoryListing object, which adds elements to it.
-  Dart_Handle results =
-      Dart_New(DartUtils::GetDartType(DartUtils::kCoreLibURL, "List"),
-               Dart_Null(),
-               0,
-               NULL);
-  if (Dart_IsError(results)) {
-    Dart_PropagateError(results);
-  }
   SyncDirectoryListing sync_listing(results,
                                     DartUtils::GetStringValue(path),
                                     DartUtils::GetBooleanValue(recursive),
                                     DartUtils::GetBooleanValue(follow_links));
   Directory::List(&sync_listing);
-  Dart_SetReturnValue(args, results);
 }
 
 
 static const int kAsyncDirectoryListerFieldIndex = 0;
 
 
 void FUNCTION_NAME(Directory_GetAsyncDirectoryListerPointer)(
     Dart_NativeArguments args) {
   AsyncDirectoryListing* listing;
   Dart_Handle dart_this = ThrowIfError(Dart_GetNativeArgument(args, 0));
@@ skipping 250 matching lines @@
   response->SetAt(2, err);
   array_->SetAt(index_++, response);
   return index_ < length_;
 }
 
 
 bool SyncDirectoryListing::HandleDirectory(const char* dir_name) {
   Dart_Handle dir_name_dart = DartUtils::NewString(dir_name);
   Dart_Handle dir =
       Dart_New(directory_type_, Dart_Null(), 1, &dir_name_dart);
-  Dart_Invoke(results_, add_string_, 1, &dir);
+  Dart_Handle result = Dart_Invoke(results_, add_string_, 1, &dir);
+  if (Dart_IsError(result)) {
+    Dart_PropagateError(result);
+  }
   return true;
 }
 
 
 bool SyncDirectoryListing::HandleLink(const char* link_name) {
   Dart_Handle link_name_dart = DartUtils::NewString(link_name);
   Dart_Handle link =
       Dart_New(link_type_, Dart_Null(), 1, &link_name_dart);
-  Dart_Invoke(results_, add_string_, 1, &link);
+  Dart_Handle result = Dart_Invoke(results_, add_string_, 1, &link);
+  if (Dart_IsError(result)) {
+    Dart_PropagateError(result);
+  }
   return true;
 }
 
 
 bool SyncDirectoryListing::HandleFile(const char* file_name) {
   Dart_Handle file_name_dart = DartUtils::NewString(file_name);
   Dart_Handle file =
       Dart_New(file_type_, Dart_Null(), 1, &file_name_dart);
-  Dart_Invoke(results_, add_string_, 1, &file);
+  Dart_Handle result = Dart_Invoke(results_, add_string_, 1, &file);
+  if (Dart_IsError(result)) {
+    Dart_PropagateError(result);
+  }
   return true;
 }
 
 
 bool SyncDirectoryListing::HandleError() {
   Dart_Handle dart_os_error = DartUtils::NewDartOSError();
   Dart_Handle args[3];
   args[0] = DartUtils::NewString("Directory listing failed");
   args[1] = DartUtils::NewString(error() ? "Invalid path" : CurrentPath());
   args[2] = dart_os_error;
@@ skipping 45 matching lines @@
     listing->HandleDone();
   } else {
     while (ListNext(listing)) {}
   }
 }
 
 }  // namespace bin
 }  // namespace dart
 
 #endif  // !defined(DART_IO_DISABLED)