components/autofill/core/browser/autofill_external_delegate.cc - Issue 19044005: Merge 210229 "Hide autofill popup before WebContentsImpl is dest..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/autofill_external_delegate.cc

Issue 19044005: Merge 210229 "Hide autofill popup before WebContentsImpl is dest..." (Closed) Base URL: svn://svn.chromium.org/chrome/branches/1547/src/

Patch Set: Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/autofill/core/browser/autofill_external_delegate.cc

===================================================================

--- components/autofill/core/browser/autofill_external_delegate.cc (revision 211372)

+++ components/autofill/core/browser/autofill_external_delegate.cc (working copy)

@@ -182,8 +182,11 @@

void AutofillExternalDelegate::OnPopupHidden(

content::KeyboardListener* listener) {

- if (registered_keyboard_listener_with_ == web_contents_->GetRenderViewHost())

+ if ((!web_contents_->IsBeingDestroyed()) &&

+ (registered_keyboard_listener_with_ ==

+ web_contents_->GetRenderViewHost())) {

web_contents_->GetRenderViewHost()->RemoveKeyboardListener(listener);

+ }

registered_keyboard_listener_with_ = NULL;

}

« no previous file with comments | « chrome/browser/ui/autofill/tab_autofill_manager_delegate.cc ('k') | no next file » | no next file with comments »