Merge 210229 "Hide autofill popup before WebContentsImpl is dest..."

Merge 210229 "Hide autofill popup before WebContentsImpl is dest..."

> Hide autofill popup before WebContentsImpl is destroyed.
> 
> TabAutofillManagerDelegate was initiating the autofill popup hiding process in
> its destructor. However, this process ends up calling back into the
> WebContentsImpl instance via a virtual method call on the base WebContents
> class. As TabAutofillManagerDelegate is a WebContentsUserData and thus has its
> destructor called as part of the WebContents base class destructor, the call
> into WebContents is occurring when the instance's vtable is that of
> WebContents, where the method is pure virtual.
> 
> This CL changes the autofill popup hiding process to occur on receiving the
> WebContentsDestroyed notification, while the vtable of the WebContents instance
> is still that of WebContentsImpl.
> 
> BUG=254490
> TEST=On Windows, cause an autofill popup to appear and close the tab. The app
> should not crash.
> 
> Review URL: https://chromiumcodereview.appspot.com/18272015

TBR=blundell@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=211373

[blundell, 2013-07-12 10:48:36]

Committed patchset #1 manually as r211373.

[blundell, 2013-07-12 10:52:09]

lgtm