Issue 1904113002: Revert "Segment strings on dot and comma in addition to space and tab"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1904113002: Revert "Segment strings on dot and comma in addition to space and tab" (Closed)

Created:
4 years, 8 months ago by eae

Modified:
4 years, 8 months ago

Reviewers:
lushnikov

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2704

Target Ref:
refs/pending/branch-heads/2704

Project:
chromium

Visibility:
Public.

Revert "Segment strings on dot and comma in addition to space and tab" Revert r386022 (commit 63f4a420e42667f2167b7fcf4a9ac8e10f66e792) as the anticipated performance win from the speculative change didn't pan out. BUG=593679 TBR=lushnikov@chromium.org Review URL: https://codereview.chromium.org/1884463005 Cr-Commit-Position: refs/heads/master@{#388291} (cherry picked from commit 72e9e09a5a7c36eb6d8eda68a9eda1757eda3294) Committed: https://chromium.googlesource.com/chromium/src/+/234a616c325f1c0e5742971f2d4fb160239e0c92

Created: 4 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1217 lines, -18 lines)			Patch
M	third_party/WebKit/LayoutTests/TestExpectations	View	2 chunks	+1214 lines, -1 line	0 comments	Download
M	third_party/WebKit/Source/platform/fonts/shaping/CachingWordShapeIterator.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	third_party/WebKit/Source/platform/fonts/shaping/CachingWordShaperTest.cpp	View	2 chunks	+2 lines, -15 lines	0 comments	Download

Total messages: 2 (1 generated)

eae

4 years, 8 months ago (2016-04-21 16:28:19 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
234a616c325f1c0e5742971f2d4fb160239e0c92.