Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 1884463005: Revert "Segment strings on dot and comma in addition to space and tab" (Closed)

Created:
4 years, 8 months ago by eae
Modified:
4 years, 8 months ago
Reviewers:
lushnikov
CC:
chromium-reviews, krit, pdr+graphicswatchlist_chromium.org, drott+blinkwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, dshwang, jbroman, Justin Novosad, Rik, Stephen Chennney, blink-reviews, f(malita), danakj+watch_chromium.org, kinuko+watch, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Segment strings on dot and comma in addition to space and tab" Revert r386022 (commit 63f4a420e42667f2167b7fcf4a9ac8e10f66e792) as the anticipated performance win from the speculative change didn't pan out. BUG=593679 TBR=lushnikov@chromium.org Committed: https://crrev.com/72e9e09a5a7c36eb6d8eda68a9eda1757eda3294 Cr-Commit-Position: refs/heads/master@{#388291}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1202 lines, -18 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 2 chunks +1199 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/fonts/shaping/CachingWordShapeIterator.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/shaping/CachingWordShaperTest.cpp View 2 chunks +2 lines, -15 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1884463005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1884463005/1
4 years, 8 months ago (2016-04-13 00:31:06 UTC) #2
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/211446)
4 years, 8 months ago (2016-04-13 01:41:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1884463005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1884463005/20001
4 years, 8 months ago (2016-04-19 17:03:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1884463005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1884463005/40001
4 years, 8 months ago (2016-04-19 18:51:44 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-04-19 20:08:02 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:15:38 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/72e9e09a5a7c36eb6d8eda68a9eda1757eda3294
Cr-Commit-Position: refs/heads/master@{#388291}

Powered by Google App Engine
This is Rietveld 408576698