Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1746)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 19041006: Send video frames backed by textures to WebRTC. (Closed)

Created:
7 years, 5 months ago by wuchengli
Modified:
7 years, 3 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Send video frames backed by textures to WebRTC. The dependent CLs: webrtc: https://webrtc-codereview.appspot.com/1966004/ libjingle: http://cl/49270949-p10 BUG=170345 TEST=Try http://apprtc.appspot.com/?debug=loopback on Chromebook Daisy. Play hardware-accelerated video. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=219526

Patch Set 1 : initial patchset #

Total comments: 2

Patch Set 2 : remove SetHandle and use ctor instead #

Total comments: 2

Patch Set 3 : rebase #

Patch Set 4 : add explicit to single-arg ctor #

Patch Set 5 : rebase #

Patch Set 6 : rebase #

Patch Set 7 : rebase #

Patch Set 8 : rebase #

Patch Set 9 : fix clang error #

Total comments: 2

Patch Set 10 : add DISALLOW_COPY_AND_ASSIGN #

Patch Set 11 : rebase #

Patch Set 12 : rebase #

Patch Set 13 : rebase #

Patch Set 14 : rebase #

Patch Set 15 : build native_handle_impl and rtc_video_renderer only when enable_webrtc=1 #

Patch Set 16 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -27 lines) Patch
M content/content_renderer.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 3 chunks +4 lines, -2 lines 0 comments Download
A content/renderer/media/native_handle_impl.h View 1 2 3 4 5 6 7 8 9 1 chunk +32 lines, -0 lines 0 comments Download
A content/renderer/media/native_handle_impl.cc View 1 2 3 4 5 6 7 8 1 chunk +16 lines, -0 lines 0 comments Download
M content/renderer/media/rtc_video_decoder.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +5 lines, -6 lines 0 comments Download
M content/renderer/media/rtc_video_renderer.cc View 2 chunks +25 lines, -19 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
wuchengli
Ami. This is the CL separated from https://codereview.chromium.org/13890012/. You should have already reviewed all of ...
7 years, 5 months ago (2013-07-12 13:05:11 UTC) #1
Ami GONE FROM CHROMIUM
LGTM % nit https://codereview.chromium.org/19041006/diff/3007/content/renderer/media/native_handle_impl.h File content/renderer/media/native_handle_impl.h (right): https://codereview.chromium.org/19041006/diff/3007/content/renderer/media/native_handle_impl.h#newcode17 content/renderer/media/native_handle_impl.h:17: virtual void SetHandle(void* handle) OVERRIDE; Any ...
7 years, 5 months ago (2013-07-12 17:35:26 UTC) #2
wuchengli
Done. https://codereview.chromium.org/19041006/diff/3007/content/renderer/media/native_handle_impl.h File content/renderer/media/native_handle_impl.h (right): https://codereview.chromium.org/19041006/diff/3007/content/renderer/media/native_handle_impl.h#newcode17 content/renderer/media/native_handle_impl.h:17: virtual void SetHandle(void* handle) OVERRIDE; On 2013/07/12 17:35:26, ...
7 years, 5 months ago (2013-07-15 06:35:14 UTC) #3
Ami GONE FROM CHROMIUM
LGTM https://codereview.chromium.org/19041006/diff/7001/content/renderer/media/native_handle_impl.h File content/renderer/media/native_handle_impl.h (right): https://codereview.chromium.org/19041006/diff/7001/content/renderer/media/native_handle_impl.h#newcode17 content/renderer/media/native_handle_impl.h:17: NativeHandleImpl(scoped_refptr<media::VideoFrame> frame); style: single-arg ctor's require "explicit" keyword
7 years, 5 months ago (2013-07-15 17:38:37 UTC) #4
wuchengli
https://codereview.chromium.org/19041006/diff/7001/content/renderer/media/native_handle_impl.h File content/renderer/media/native_handle_impl.h (right): https://codereview.chromium.org/19041006/diff/7001/content/renderer/media/native_handle_impl.h#newcode17 content/renderer/media/native_handle_impl.h:17: NativeHandleImpl(scoped_refptr<media::VideoFrame> frame); On 2013/07/15 17:38:37, Ami Fischman wrote: > ...
7 years, 5 months ago (2013-07-16 08:55:21 UTC) #5
wuchengli
WebRTC and libjingle got rolled. This CL can be submitted. @piman: OWNER's review for content/content_renderer.gypi. ...
7 years, 4 months ago (2013-08-07 08:52:20 UTC) #6
piman
LGTM+nit https://codereview.chromium.org/19041006/diff/41001/content/renderer/media/native_handle_impl.h File content/renderer/media/native_handle_impl.h (right): https://codereview.chromium.org/19041006/diff/41001/content/renderer/media/native_handle_impl.h#newcode25 content/renderer/media/native_handle_impl.h:25: scoped_refptr<media::VideoFrame> frame_; nit: DISALLOW_COPY_AND_ASSIGN
7 years, 4 months ago (2013-08-07 19:09:17 UTC) #7
wuchengli
Done. Submitting. https://codereview.chromium.org/19041006/diff/41001/content/renderer/media/native_handle_impl.h File content/renderer/media/native_handle_impl.h (right): https://codereview.chromium.org/19041006/diff/41001/content/renderer/media/native_handle_impl.h#newcode25 content/renderer/media/native_handle_impl.h:25: scoped_refptr<media::VideoFrame> frame_; On 2013/08/07 19:09:17, piman wrote: ...
7 years, 4 months ago (2013-08-08 05:03:00 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wuchengli@chromium.org/19041006/46001
7 years, 4 months ago (2013-08-08 09:55:42 UTC) #9
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 4 months ago (2013-08-08 19:53:16 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wuchengli@chromium.org/19041006/94001
7 years, 3 months ago (2013-08-26 07:53:28 UTC) #11
commit-bot: I haz the power
7 years, 3 months ago (2013-08-26 12:39:58 UTC) #12
Message was sent while issue was closed. 
Change committed as 219526

Powered by Google App Engine
This is Rietveld 408576698