Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorSession.cpp

Issue 1903953002: [DevTools] Move from InstrumentingAgents to InstrumentingSessions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove-discard-agent
Patch Set: rebased Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/InspectorSession.cpp
diff --git a/third_party/WebKit/Source/core/inspector/InspectorSession.cpp b/third_party/WebKit/Source/core/inspector/InspectorSession.cpp
index 25a14afa2c8c11a28cc04bd30215e308ced8cf71..4dc20ee527281dba3343a172de0efb10cb6befa4 100644
--- a/third_party/WebKit/Source/core/inspector/InspectorSession.cpp
+++ b/third_party/WebKit/Source/core/inspector/InspectorSession.cpp
@@ -4,22 +4,21 @@
#include "core/inspector/InspectorSession.h"
+#include "core/InstrumentingAgents.h"
#include "core/inspector/InspectorBaseAgent.h"
#include "core/inspector/InspectorInstrumentation.h"
#include "platform/inspector_protocol/Backend.h"
-#include "platform/inspector_protocol/Dispatcher.h"
-#include "platform/inspector_protocol/Frontend.h"
#include "platform/inspector_protocol/Parser.h"
#include "platform/inspector_protocol/TypeBuilder.h"
namespace blink {
-InspectorSession::InspectorSession(Client* client, int sessionId, InstrumentingAgents* instrumentingAgents, bool autoFlush)
+InspectorSession::InspectorSession(Client* client, int sessionId, bool autoFlush)
: m_client(client)
, m_sessionId(sessionId)
, m_autoFlush(autoFlush)
, m_attached(false)
- , m_instrumentingAgents(instrumentingAgents)
+ , m_instrumentingAgents(new InstrumentingAgents())
, m_inspectorFrontend(adoptPtr(new protocol::Frontend(this)))
, m_inspectorBackendDispatcher(protocol::Dispatcher::create(this))
{
@@ -67,7 +66,6 @@ void InspectorSession::detach()
m_agents[i - 1]->dispose();
m_inspectorFrontend.clear();
m_agents.clear();
- m_instrumentingAgents->reset();
InspectorInstrumentation::frontendDeleted();
}

Powered by Google App Engine
This is Rietveld 408576698