Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1903893003: Fix strong mode errors in SVG (Closed)

Created:
4 years, 8 months ago by Jacob
Modified:
4 years, 8 months ago
Reviewers:
Alan Knight
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -20 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 2 chunks +4 lines, -7 lines 0 comments Download
M sdk/lib/svg/dart2js/svg_dart2js.dart View 2 chunks +4 lines, -12 lines 0 comments Download
M tools/dom/scripts/systemhtml.py View 1 3 chunks +30 lines, -1 line 2 comments Download

Messages

Total messages: 6 (2 generated)
Jacob
4 years, 8 months ago (2016-04-21 19:33:18 UTC) #2
Alan Knight
lgtm https://codereview.chromium.org/1903893003/diff/20001/tools/dom/scripts/systemhtml.py File tools/dom/scripts/systemhtml.py (right): https://codereview.chromium.org/1903893003/diff/20001/tools/dom/scripts/systemhtml.py#newcode26 tools/dom/scripts/systemhtml.py:26: # these sets based on manual triage ofstrong ...
4 years, 8 months ago (2016-04-21 19:37:07 UTC) #3
Jacob
https://codereview.chromium.org/1903893003/diff/20001/tools/dom/scripts/systemhtml.py File tools/dom/scripts/systemhtml.py (right): https://codereview.chromium.org/1903893003/diff/20001/tools/dom/scripts/systemhtml.py#newcode26 tools/dom/scripts/systemhtml.py:26: # these sets based on manual triage ofstrong mode ...
4 years, 8 months ago (2016-04-21 19:42:41 UTC) #4
Jacob
4 years, 8 months ago (2016-04-21 19:45:13 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
819ed4bb60a92c97f8a0c8e51a1c7918290c93a5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698