Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Unified Diff: sdk/lib/svg/dart2js/svg_dart2js.dart

Issue 1903893003: Fix strong mode errors in SVG (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/svg/dart2js/svg_dart2js.dart
diff --git a/sdk/lib/svg/dart2js/svg_dart2js.dart b/sdk/lib/svg/dart2js/svg_dart2js.dart
index 4b967b906e9fcac6b6c6c3398bfe718bf1ee3007..e15ec4f7d7458598035b46612adcd4dd80fdf01a 100644
--- a/sdk/lib/svg/dart2js/svg_dart2js.dart
+++ b/sdk/lib/svg/dart2js/svg_dart2js.dart
@@ -4646,12 +4646,8 @@ class StyleElement extends SvgElement {
@Experimental() // untriaged
final StyleSheet sheet;
- // Shadowing definition.
- String get title => JS("String", "#.title", this);
-
- set title(String value) {
- JS("void", "#.title = #", this, value);
- }
+ // Use implementation from Element.
+ // final String title;
@DomName('SVGStyleElement.type')
@DocsEditable()
@@ -5085,12 +5081,8 @@ class SvgElement extends Element implements GlobalEventHandlers {
// Use implementation from Element.
// final CssStyleDeclaration style;
- // Shadowing definition.
- int get tabIndex => JS("int", "#.tabIndex", this);
-
- set tabIndex(int value) {
- JS("void", "#.tabIndex = #", this, value);
- }
+ // Use implementation from Element.
+ // final int tabIndex;
@DomName('SVGElement.viewportElement')
@DocsEditable()

Powered by Google App Engine
This is Rietveld 408576698