Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 1903873004: Deprecate window.postMessage(m, transferables, origin) overload. (Closed)

Created:
4 years, 8 months ago by sof
Modified:
4 years, 7 months ago
CC:
blink-reviews, blink-reviews-bindings_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Deprecate window.postMessage(m, transferables, origin) overload. This argument-swapped legacy overload has little use, hence it is time to try to phase it out. Deprecate with view to removing in M54. Intent: https://groups.google.com/a/chromium.org/d/msg/blink-dev/h4ooaB_Y9JE/nh7vXshGBwAJ R= BUG=425896 Committed: https://crrev.com/48b609eca30c2bbcb91d74bc311f0fd34b030ab4 Cr-Commit-Position: refs/heads/master@{#389800}

Patch Set 1 #

Patch Set 2 : update test expectations #

Patch Set 3 : revert unrelated expectation rebaseline #

Total comments: 2

Patch Set 4 : give API alternative in deprecation message #

Patch Set 5 : rebased #

Messages

Total messages: 16 (7 generated)
sof
please take a look. Following up on https://groups.google.com/a/chromium.org/d/msg/blink-dev/h4ooaB_Y9JE/nh7vXshGBwAJ
4 years, 8 months ago (2016-04-21 09:51:53 UTC) #3
jochen (gone - plz use gerrit)
lgtm
4 years, 8 months ago (2016-04-21 09:59:13 UTC) #4
philipj_slow
lgtm https://codereview.chromium.org/1903873004/diff/40001/third_party/WebKit/Source/core/frame/Deprecation.cpp File third_party/WebKit/Source/core/frame/Deprecation.cpp (right): https://codereview.chromium.org/1903873004/diff/40001/third_party/WebKit/Source/core/frame/Deprecation.cpp#newcode368 third_party/WebKit/Source/core/frame/Deprecation.cpp:368: return willBeRemoved("'window.postMessage(message, transferables, targetOrigin)'", 54, "5719033043222528"); Maybe replacedWillBeRemoved ...
4 years, 8 months ago (2016-04-21 10:03:29 UTC) #5
sof
https://codereview.chromium.org/1903873004/diff/40001/third_party/WebKit/Source/core/frame/Deprecation.cpp File third_party/WebKit/Source/core/frame/Deprecation.cpp (right): https://codereview.chromium.org/1903873004/diff/40001/third_party/WebKit/Source/core/frame/Deprecation.cpp#newcode368 third_party/WebKit/Source/core/frame/Deprecation.cpp:368: return willBeRemoved("'window.postMessage(message, transferables, targetOrigin)'", 54, "5719033043222528"); On 2016/04/21 10:03:29, ...
4 years, 8 months ago (2016-04-21 10:18:39 UTC) #6
haraken
LGTM
4 years, 8 months ago (2016-04-21 10:26:12 UTC) #8
sof
moving ahead w/ deprecation-to-be-removed-in-M54.
4 years, 7 months ago (2016-04-26 14:53:59 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1903873004/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1903873004/80001
4 years, 7 months ago (2016-04-26 14:54:33 UTC) #12
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 7 months ago (2016-04-26 16:19:54 UTC) #14
commit-bot: I haz the power
4 years, 7 months ago (2016-04-26 16:21:31 UTC) #16
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/48b609eca30c2bbcb91d74bc311f0fd34b030ab4
Cr-Commit-Position: refs/heads/master@{#389800}

Powered by Google App Engine
This is Rietveld 408576698