third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp - Issue 1903873004: Deprecate window.postMessage(m, transferables, origin) overload.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp

Issue 1903873004: Deprecate window.postMessage(m, transferables, origin) overload. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebased Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/events/message-port-inactive-document.html ('k') | third_party/WebKit/Source/core/frame/Deprecation.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp b/third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp

index b1badd5fbc5eb331299a6d651644ccf09e875d7f..1c427411cb77514abc50541c3ab1579893482af2 100644

--- a/third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp

@@ -46,6 +46,7 @@

#include "bindings/core/v8/V8Node.h"

#include "core/dom/DOMArrayBuffer.h"

#include "core/dom/MessagePort.h"

+#include "core/frame/Deprecation.h"

#include "core/frame/FrameView.h"

#include "core/frame/ImageBitmap.h"

#include "core/frame/LocalDOMWindow.h"

@@ -197,7 +198,7 @@ void V8Window::postMessageMethodCustom(const v8::FunctionCallbackInfo<v8::Value>

if (info.Length() > 2) {

int transferablesArgIndex = 2;

if (isLegacyTargetOriginDesignation(info[2])) {

- UseCounter::countIfNotPrivateScript(info.GetIsolate(), window->frame(), UseCounter::WindowPostMessageWithLegacyTargetOriginArgument);

+ Deprecation::countDeprecationIfNotPrivateScript(info.GetIsolate(), window->document(), UseCounter::WindowPostMessageWithLegacyTargetOriginArgument);

targetOriginArgIndex = 2;

transferablesArgIndex = 1;

}