Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1246)

Unified Diff: blimp/engine/app/engine_settings.h

Issue 1903873003: blimp: Update animation policy for images on the blimp engine. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | blimp/engine/app/engine_settings.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: blimp/engine/app/engine_settings.h
diff --git a/blimp/engine/app/engine_settings.h b/blimp/engine/app/engine_settings.h
index 99d5663a4a2c7a3d741c07de849a48290d8267d2..4ae7f288a991506a66cd089fe4bb4a29eef2812f 100644
--- a/blimp/engine/app/engine_settings.h
+++ b/blimp/engine/app/engine_settings.h
@@ -5,16 +5,28 @@
#ifndef BLIMP_ENGINE_APP_ENGINE_SETTINGS_H_
#define BLIMP_ENGINE_APP_ENGINE_SETTINGS_H_
+#include "content/public/common/web_preferences.h"
+
namespace blimp {
namespace engine {
+// The EngineSettings includes all parameters which are configured for the
+// BlimpEngine and can be set by the client. This includes the values for
+// content::WebPreferences which override the default values.
struct EngineSettings {
- // -------WebPreferences-------
- bool record_whole_document;
-
EngineSettings();
Wez 2016/04/21 17:29:02 Since this struct is pure POD I think you can decl
Khushal 2016/04/21 18:45:48 Done.
EngineSettings(const EngineSettings& other);
~EngineSettings();
Wez 2016/04/21 17:29:02 Do you actually need an explicit copy ctor and dto
Khushal 2016/04/21 18:45:48 Nope. Removed.
+
+ // -------WebPreferences-------
+ // These members mirror the parameters in content::WebPreferences. See
+ // content/public/common/web_preferences.h for details.
+
+ bool record_whole_document = false;
+
+ // Disable animation in images by default.
+ content::ImageAnimationPolicy animation_policy =
+ content::ImageAnimationPolicy::IMAGE_ANIMATION_POLICY_NO_ANIMATION;
};
} // namespace engine
« no previous file with comments | « no previous file | blimp/engine/app/engine_settings.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698