Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Side by Side Diff: blimp/engine/app/engine_settings.h

Issue 1903873003: blimp: Update animation policy for images on the blimp engine. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | blimp/engine/app/engine_settings.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef BLIMP_ENGINE_APP_ENGINE_SETTINGS_H_ 5 #ifndef BLIMP_ENGINE_APP_ENGINE_SETTINGS_H_
6 #define BLIMP_ENGINE_APP_ENGINE_SETTINGS_H_ 6 #define BLIMP_ENGINE_APP_ENGINE_SETTINGS_H_
7 7
8 #include "content/public/common/web_preferences.h"
9
8 namespace blimp { 10 namespace blimp {
9 namespace engine { 11 namespace engine {
10 12
13 // The EngineSettings includes all parameters which are configured for the
14 // BlimpEngine and can be set by the client. This includes the values for
15 // content::WebPreferences which override the default values.
11 struct EngineSettings { 16 struct EngineSettings {
12 // -------WebPreferences-------
13 bool record_whole_document;
14
15 EngineSettings(); 17 EngineSettings();
Wez 2016/04/21 17:29:02 Since this struct is pure POD I think you can decl
Khushal 2016/04/21 18:45:48 Done.
16 EngineSettings(const EngineSettings& other); 18 EngineSettings(const EngineSettings& other);
17 ~EngineSettings(); 19 ~EngineSettings();
Wez 2016/04/21 17:29:02 Do you actually need an explicit copy ctor and dto
Khushal 2016/04/21 18:45:48 Nope. Removed.
20
21 // -------WebPreferences-------
22 // These members mirror the parameters in content::WebPreferences. See
23 // content/public/common/web_preferences.h for details.
24
25 bool record_whole_document = false;
26
27 // Disable animation in images by default.
28 content::ImageAnimationPolicy animation_policy =
29 content::ImageAnimationPolicy::IMAGE_ANIMATION_POLICY_NO_ANIMATION;
18 }; 30 };
19 31
20 } // namespace engine 32 } // namespace engine
21 } // namespace blimp 33 } // namespace blimp
22 34
23 #endif // BLIMP_ENGINE_APP_ENGINE_SETTINGS_H_ 35 #endif // BLIMP_ENGINE_APP_ENGINE_SETTINGS_H_
OLDNEW
« no previous file with comments | « no previous file | blimp/engine/app/engine_settings.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698