Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 // Copyright 2016 The Chromium Authors. All rights reserved. | 1 // Copyright 2016 The Chromium Authors. All rights reserved. |
| 2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
| 3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
| 4 | 4 |
| 5 #ifndef BLIMP_ENGINE_APP_ENGINE_SETTINGS_H_ | 5 #ifndef BLIMP_ENGINE_APP_ENGINE_SETTINGS_H_ |
| 6 #define BLIMP_ENGINE_APP_ENGINE_SETTINGS_H_ | 6 #define BLIMP_ENGINE_APP_ENGINE_SETTINGS_H_ |
| 7 | 7 |
| 8 #include "content/public/common/web_preferences.h" | |
| 9 | |
| 8 namespace blimp { | 10 namespace blimp { |
| 9 namespace engine { | 11 namespace engine { |
| 10 | 12 |
| 13 // The EngineSettings includes all parameters which are configured for the | |
| 14 // BlimpEngine and can be set by the client. This includes the values for | |
| 15 // content::WebPreferences which override the default values. | |
| 11 struct EngineSettings { | 16 struct EngineSettings { |
| 12 // -------WebPreferences------- | |
| 13 bool record_whole_document; | |
| 14 | |
| 15 EngineSettings(); | 17 EngineSettings(); |
|
Wez
2016/04/21 17:29:02
Since this struct is pure POD I think you can decl
Khushal
2016/04/21 18:45:48
Done.
| |
| 16 EngineSettings(const EngineSettings& other); | 18 EngineSettings(const EngineSettings& other); |
| 17 ~EngineSettings(); | 19 ~EngineSettings(); |
|
Wez
2016/04/21 17:29:02
Do you actually need an explicit copy ctor and dto
Khushal
2016/04/21 18:45:48
Nope. Removed.
| |
| 20 | |
| 21 // -------WebPreferences------- | |
| 22 // These members mirror the parameters in content::WebPreferences. See | |
| 23 // content/public/common/web_preferences.h for details. | |
| 24 | |
| 25 bool record_whole_document = false; | |
| 26 | |
| 27 // Disable animation in images by default. | |
| 28 content::ImageAnimationPolicy animation_policy = | |
| 29 content::ImageAnimationPolicy::IMAGE_ANIMATION_POLICY_NO_ANIMATION; | |
| 18 }; | 30 }; |
| 19 | 31 |
| 20 } // namespace engine | 32 } // namespace engine |
| 21 } // namespace blimp | 33 } // namespace blimp |
| 22 | 34 |
| 23 #endif // BLIMP_ENGINE_APP_ENGINE_SETTINGS_H_ | 35 #endif // BLIMP_ENGINE_APP_ENGINE_SETTINGS_H_ |
| OLD | NEW |