Handle non-power-of-2 divisors in division-like operations

Handle non-power-of-2 divisors in division-like operations

R=bmeurer@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=19719

[Benedikt Meurer, 2014-03-07 11:27:37]

LGTM

[m.m.capewell, 2014-03-07 11:37:29]

https://codereview.chromium.org/190383002/diff/1/src/a64/macro-assembler-a64.cc
File src/a64/macro-assembler-a64.cc (right):

https://codereview.chromium.org/190383002/diff/1/src/a64/macro-assembler-a64....
src/a64/macro-assembler-a64.cc:4939: ASSERT(!AreAliased(dividend, result, tmp));
Also assert that result and dividend are W registers.

https://codereview.chromium.org/190383002/diff/1/src/a64/macro-assembler-a64....
src/a64/macro-assembler-a64.cc:4943: Mov(result.X(), Operand(result.X(), ASR,
32));
Asr(result.X(), result.X(), 32);

https://codereview.chromium.org/190383002/diff/1/src/a64/macro-assembler-a64....
src/a64/macro-assembler-a64.cc:4945: Add(result, result, Operand(dividend));
Don't need Operand here.

https://codereview.chromium.org/190383002/diff/1/src/a64/macro-assembler-a64....
src/a64/macro-assembler-a64.cc:4948: Sub(result, result, Operand(dividend));
Don't need Operand here.

https://codereview.chromium.org/190383002/diff/1/src/a64/macro-assembler-a64....
src/a64/macro-assembler-a64.cc:4950: if (ms.shift() > 0) Mov(result,
Operand(result, ASR, ms.shift()));
Asr(result, result, ms.shift());

https://codereview.chromium.org/190383002/diff/20001/src/a64/lithium-codegen-...
File src/a64/lithium-codegen-a64.cc (right):

https://codereview.chromium.org/190383002/diff/20001/src/a64/lithium-codegen-...
src/a64/lithium-codegen-a64.cc:2633: __ Cmp(dividend, 0);
DeoptimizeIfZero()

[Sven Panne, 2014-03-07 11:44:22]

Committed patchset #3 manually as r19719 (presubmit successful).

[Sven Panne, 2014-03-07 11:46:33]

On 2014/03/07 11:37:29, m.m.capewell wrote:
> [...]

Ooops, the comments slipped between the LGTM and the actual commit, caused by a
rebase orgy. :-P I'll handle these in a separate CL...